Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts for when flair apps pile up #74

Open
Raia opened this issue Oct 12, 2017 · 4 comments
Open

Alerts for when flair apps pile up #74

Raia opened this issue Oct 12, 2017 · 4 comments
Assignees

Comments

@Raia
Copy link
Member

Raia commented Oct 12, 2017

No description provided.

@not-an-aardvark
Copy link
Contributor

This could be tricky because we would need to give Porygon-Bot privileged access to the FlairHQ database or API, which it doesn't have at the moment.

@pkmnbumba
Copy link
Contributor

Should the goal be eventually a line that encompasses both this and #67? Or should this be a different notification? I feel like a line that says 'X number of reports & X number of flair apps' would be most efficient and reduce notification clutter.

@Kirzi
Copy link

Kirzi commented Oct 24, 2017

I would prefer to keep it separate. One more line doesn't hurt anyone, and it'd probably be more legible that way.

Plus, frequency would be different. We discussed doing notifications for flair apps every 1-2 hours, but maybe once every 3-4 hours would be better.


Also, while I'm here...

Based on IRC discussion, we'd want notifications for both the number of flair apps, and for flair apps being open for too long, and there would only be notifications when we reach a certain threshold.

For the actual threshold, maybe 5-10? 5 is low enough that it's easy for one person to knock out without much difficulty, but may be a bit low and result in us being notified of apps more often than we'd want. I'm not sure how often they come in.

Also, since our flair guide says we'll get to apps within "a few days", we should probably start doing notifications for outstanding apps at the 2 day mark.

If there are just too many apps, the actual notification could look something like this:

[FLAIR APP ALERT] There are x flair applications in FlairHQ. https://hq.porygon.co/

If there are apps open for too long:

[FLAIR APP ALERT] There are x flair applications, y of which have been outstanding for more than 2 days. https://hq.porygon.co/

@pkmnbumba
Copy link
Contributor

Would it be okay to create a new page (maybe https://hq.porygon.co/flair/apps/queue) that is public so that the bot can grab it? We could remove all the unnecessary info (basically just listing out the creation dates). That way we can grab the date of the oldest app as well as the number of apps.

I think this is what was proposed before as an alternative to giving porygon-bot more access.

@pkmnbumba pkmnbumba self-assigned this Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants