Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banlist hover #640

Closed
wants to merge 5 commits into from
Closed

Banlist hover #640

wants to merge 5 commits into from

Conversation

robdy
Copy link
Member

@robdy robdy commented Jul 4, 2018

Fixes #582. Changed 'Retrading allowed' to inline radio and added new field:
image

Result:
image

@Kirzi
Copy link
Contributor

Kirzi commented Jul 5, 2018

I think ideally, the "hover note" box is hidden unless "some" is selected, since it turns out that it's not really needed much. But I'm fine with this as is. Thanks for working on it.

@robdy
Copy link
Member Author

robdy commented Jul 5, 2018

I initially left it visible as there was one entry with Yes (hover) but perhaps you're right that it won't probably be used. Will fix it a bit later.

Edit; would be good to add some basic checking so that Some always go with hover (note to myself).

@robdy
Copy link
Member Author

robdy commented Jul 8, 2018

Ok, all done (hiding + check if empty).

@Kirzi
Copy link
Contributor

Kirzi commented Jul 9, 2018

Looks good to me, thanks. (tested to check the look/behavior but didn't test an actual ban)

@Raia
Copy link
Member

Raia commented Nov 14, 2018

Will try to review this sometime soon ✌️

@Raia Raia self-assigned this Nov 14, 2018
@AlMcKinlay
Copy link
Contributor

Soon never came. Closing as this will also be superceded.

@AlMcKinlay AlMcKinlay closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in banlist hover feature
4 participants