Rare case, but increasing id may cause overflow error

[hmhv]

swift-perception/Sources/Perception/WithPerceptionTracking.swift

Lines 47 to 62 in 41581ed

	@State var id = 0
	let content: () -> Content
	public var body: Content {
	if #available(iOS 17, macOS 14, tvOS 17, watchOS 10, *) {
	return self.instrumentedBody()
	} else {
	// NB: View will not re-render when 'id' changes unless we access it in the view.
	let _ = self.id
	return withPerceptionTracking {
	self.instrumentedBody()
	} onChange: {
	Task { @MainActor in
	self.id += 1
	}
	}

public struct WithPerceptionTracking<Content> {
-  @State var id = 0
+  @State var id = false
  let content: () -> Content

  public var body: Content {
    if #available(iOS 17, macOS 14, tvOS 17, watchOS 10, *) {
      return self.instrumentedBody()
    } else {
      // NB: View will not re-render when 'id' changes unless we access it in the view.
      let _ = self.id
      return withPerceptionTracking {
        self.instrumentedBody()
      } onChange: {
        Task { @MainActor in
-          self.id += 1
+          self.id.toggle()
        }
      }
    }
  }

public struct WithPerceptionTracking<Content> {
  @State var id = 0
  let content: () -> Content

  public var body: Content {
    if #available(iOS 17, macOS 14, tvOS 17, watchOS 10, *) {
      return self.instrumentedBody()
    } else {
      // NB: View will not re-render when 'id' changes unless we access it in the view.
      let _ = self.id
      return withPerceptionTracking {
        self.instrumentedBody()
      } onChange: {
        Task { @MainActor in
-          self.id += 1
+          if self.id == Int.max {
+            self.id = 0
+          } else {
+            self.id += 1
+          }
        }
      }
    }
  }

[mbrandonw]

Hi @hmhv, thanks for bringing this up, but Int.max is so incredible large that even if your views re-rendered 1,000,000 times a second it would take 292,471 years to hit the overflow. So we don't think in practice it is actually going to be a problem 🙂

[hmhv]

@mbrandonw
Thank you for your kind reply!