Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the "check" requirements are not met, the coverage method is never called #37

Open
OverloadUT opened this issue Jul 4, 2015 · 4 comments

Comments

@OverloadUT
Copy link

If the "check" requirements are not met, the coverage method is never called.

The problem with this is that it means that you will never get coveralls.io to see your coverage when it's below the required threshold. This is when you would MOST want to be able to see the details of the coverage.

Right now I am having to put check at zero to force it to always go to coveralls.io, but this means that my Travis CI build shows passing when I would in fact like it to be failing when the coverage isn't good enough.

At least make it an option maybe?

@pocesar
Copy link
Owner

pocesar commented Jul 4, 2015

does it work with --force? because that's the desired behavior, it should never continue if the coverage threshold isn't met, since it won't generate coverage files if it fails, therefore we could not trigger the coverage event.

this would need to be refactor to allow the coverage files to be created and event emitted regardless of the threshold, but would break current implementations

@OverloadUT
Copy link
Author

I thought of that - the problem with --force is that it causes failures to no longer return error codes, and therefore Travis sees everything as successful.

@pocesar
Copy link
Owner

pocesar commented Aug 9, 2015

could implement a new option hardFail (that defaults to true), else it will only emit a warning and won't stop further tasks

@ngeor
Copy link

ngeor commented Sep 22, 2016

Thanks for linking to the issue I opened! Indeed they seem quite similar. Consider calling the new option noFail (that defaults to false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants