Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplicity Check in Generation Script #11

Open
pasetti opened this issue Jan 7, 2023 · 1 comment
Open

Multiplicity Check in Generation Script #11

pasetti opened this issue Jan 7, 2023 · 1 comment
Assignees

Comments

@pasetti
Copy link
Contributor

pasetti commented Jan 7, 2023

In function createCrPsDataPoolServHeaders in the Cordet FW Editor code generator, I check whether a data item is an array by checking whether its multiplicity is equal to 1. In the editor, the multiplicity is often defined through a symbolic constant. Thus, with the current implementation, function createCrPsDataPoolServHeaders treats scalars and arrays with a size 1 in the same manner. This is probably not what is intended. The multiplicity check should probably be modified to something like:

IF (there is a symbol representing the multiplicity) OR (the multiplicity is greater than 1) THEN    
   .... /* treat data item as an array */

The problem described here probably also applies to other functions in the generator.

@pasetti pasetti self-assigned this Jan 7, 2023
@pasetti
Copy link
Contributor Author

pasetti commented Jan 9, 2023

I have modified function getMultiplicity to return a third item which defines whether the argument data item is a scalar or an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant