Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff_evt breaks on empty lines #1045

Open
marijnvdwerf opened this issue May 1, 2023 · 0 comments
Open

diff_evt breaks on empty lines #1045

marijnvdwerf opened this issue May 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@marijnvdwerf
Copy link
Collaborator

If there's an empty line in symbol_addrs, diff_evt.py crashes instead of producing output

Traceback (most recent call last):
  File "/Users/marijn/Projects/papermario-jp/diff_evt.py", line 168, in <module>
    main()
  File "/Users/marijn/Projects/papermario-jp/diff_evt.py", line 165, in main
    display.run_sync()
  File "/Users/marijn/Projects/papermario-jp/diff.py", line 3276, in run_sync
    output, _ = self.run_diff()
                ^^^^^^^^^^^^^^^
  File "/Users/marijn/Projects/papermario-jp/diff_evt.py", line 60, in run_diff
    symbols = parse_symbol_addrs()
              ^^^^^^^^^^^^^^^^^^^^
  File "/Users/marijn/Projects/papermario-jp/tools/update_evts.py", line 53, in parse_symbol_addrs
    ram_addr = int(line[:line.find(";")].split("=")[1].strip(), base=0)
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range
@bates64 bates64 added the bug Something isn't working label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants