webpack4 tree-shaking fail with version 2.25.1

[maplor]

• three-stdlib version: 2.25.1

Problem description:

I use @react-three/drei for my 3D Scene in a webpack 4 project. after update three-stdlib version 2.25.1, I found that all three-stdlib.js build in the bundle. but it's ok (tree-shaking) in version 2.25.0

Suggested solution:

I found some change in this commit 644d2ad

if this is realy a bug ?

[JaimeTorrealba]

Same problem in Tresjs

we use vite is not only with webpack

[github-actions]

🎉 This issue has been resolved in version 2.26.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[CodyJasonBennett]

Reverted recent changes in #290 since we had bad downstream effects in-between. WRT tree-shaking, is that still an issue in the specific 2.26.2 version of three-stdlib?

[maplor]

Reverted recent changes in #290 since we had bad downstream effects in-between. WRT tree-shaking, is that still an issue in the specific 2.26.2 version of three-stdlib?

It seen no change

[github-actions]

🎉 This issue has been resolved in version 2.26.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[DmitryUlyanov]

Still present with version 2.26.6

[CodyJasonBennett]

Can you share a reproduction or how you're encountering this?

[DmitryUlyanov]

Sure, please find attached.

To run:

npx nx run test-treeshake:build --configuration=production

test-tree-shake.zip

See this line.

With three-stdlib 1.14mb:

With three/examples, it's 700kb.

In my project the overhead is higher.

[DmitryUlyanov]

And I just noticed on the screenshots this, but I actually did not import exporter anywhere.

[CodyJasonBennett]

I wasn't able to run the attached test suite due to missing dependencies/config, but I was able to narrow down potential issues I've fixed in v2.26.7. Can you confirm on your end that this tree-shakes precisely to GLTFLoader? Chevrotain I couldn't find anything on since we vendor it to be pure.

[DmitryUlyanov]

Updated the zip, forgot to include hidden files.

test-treeshake2.zip

With 2.26.7 I get

[CodyJasonBennett]

Ah, vendored the wrong version. Put out a hotfix in 2.26.8. I'll double check with the above files.

[alvarosabu]

Hey there, it might not be only webpack, with vite and v2.26.0 the latest release of @tresjs/cientos was tripled https://bundlephobia.com/package/@tresjs/[email protected] Tresjs/cientos#254

[CodyJasonBennett]

I have no observability unless you use the latest version. We ship sourcemaps and no longer consume most libraries from NPM by blind chance that helps here since I've received no feedback and cannot reproduce as such. On that note, I additionally have #306 which may crudely help here in bypassing the tree-shaking mechanism altogether.

[github-actions]

🎉 This issue has been resolved in version 2.27.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[alvarosabu]

@CodyJasonBennett just updated to v2.27.3 bundle-size back to normal, at least with vite 👍