More style fixes.

Author: Zsolt Lattmann

src/client/js/Widgets/DiagramDesigner/SelectionManager.js

@@ -753,7 +753,7 @@ define([
 
         this._rotateAngle = deg;
 
-        this._rotationDegree.html((deg >= 0 ? '+' : '') + deg + '°');
+        this._rotationDegree.html((deg >= 0 ? '+' : '') + deg + '°');
 
         this._diagramDesigner.skinParts.$selectionOutline.css({
             'transform-origin': '50% 50%',

src/client/js/Widgets/GraphViz/GraphVizWidget.js

@@ -115,7 +115,7 @@ define([
             d.status = d.status || getOpenStatus(d);
         });
 
-        // Update the nodes…
+        // Update the nodes ...
         var node = this._svg.selectAll('g.node')
             .data(nodes, function (d) {
                 return d.id || (d.id = ++i);
@@ -213,7 +213,7 @@ define([
         nodeExit.select('text')
             .style('fill-opacity', 1e-6);
 
-        // Update the links…
+        // Update the links ...
         var link = this._svg.selectAll('path.link')
             .data(links, function (d) {
                 return d.target.id;

src/common/blob/BlobClient.js

@@ -114,7 +114,7 @@ define(['blob/Artifact', 'blob/BlobMetadata', 'superagent'], function (Artifact,
             req.set('webgmeclientsession', this.webgmeclientsession);
         }
         if (typeof data !== 'string' && !(data instanceof String)) {
-            req.set('Content-Length', contentLength)
+            req.set('Content-Length', contentLength);
         }
         req.set('Content-Type', 'application/octet-stream')
             .send(data)

src/common/core/coretree.js

@@ -444,11 +444,13 @@ define([
         };
 
         var __isEmptyData = function (data) {
-            // TODO: better way to check if object has keys?
-            for (var keys in data) {
+            if (typeof data === 'string') {
+                return false;
+            } else if (typeof data === 'object' && Object.keys(data).length === 0) {
+                return true;
+            } else {
                 return false;
             }
-            return true;
         };
 
         var __areEquivalent = function (data1, data2) {

src/plugin/climanager.js

@@ -1,4 +1,4 @@
-/*globals requireJS*/
+/*globals*/
 /*jshint node:true*/
 /**
  * @author pmeijer / https://github.com/pmeijer

src/plugin/coreplugins/MetaGMEParadigmImporter/MetaGMEParadigmImporter.js

@@ -287,8 +287,7 @@ define([
             i,
             j,
             type,
-            types = ['atom', 'folder', 'model', 'set', 'connection', 'reference'],
-            error;
+            types = ['atom', 'folder', 'model', 'set', 'connection', 'reference'];
 
         self.logger.debug('Creating nodes ...');
 

src/server/middleware/ExampleRestRouter.js

@@ -13,8 +13,8 @@ function getUserId(req) {
 }
 
 function initialize(middlewareOpts) {
-    var gmeConfig = middlewareOpts.gmeConfig,
-        logger = middlewareOpts.logger.fork('ExampleRestRouter'),
+    var logger = middlewareOpts.logger.fork('ExampleRestRouter'),
+        //gmeConfig = middlewareOpts.gmeConfig,
         ensureAuthenticated = middlewareOpts.ensureAuthenticated;
 
     logger.debug('initializing ...');

src/server/middleware/blob/BlobError.js

@@ -1,5 +1,6 @@
-/* globals module */
+/*jshint node:true*/
 
+'use strict';
 
 module.exports = function BlobError(message, statusCode) {
     Error.captureStackTrace(this, this.constructor);

src/server/middleware/executor/ExecutorServer.js

@@ -156,7 +156,6 @@ function executorRESTWorkerAPI(req, res, next) {
     }
 
     var url = require('url').parse(req.url);
-    var pathParts = url.pathname.split('/');
 
     var serverResponse = new WorkerInfo.ServerResponse({refreshPeriod: workerRefreshInterval});
     serverResponse.labelJobs = labelJobs;

src/server/middleware/executor/worker/rjs_build_node_worker.js

@@ -12,7 +12,7 @@
         util: 'empty:',
         events: 'empty:',
         path: 'empty:',
-        child_process: 'empty:',
+        child_process: 'empty:', // jshint ignore:line
         minimatch: 'empty:',
         rimraf: 'empty:',
         url: 'empty:'
@@ -21,6 +21,6 @@
     include: ['./node_modules/requirejs/require'],
     wrap: {
         end: 'module.exports.require = require;\n' +
-        'module.exports.requirejs = requirejs;\nmodule.exports.define = define;\n'
+             'module.exports.requirejs = requirejs;\nmodule.exports.define = define;\n'
     }
-})
+});

src/server/standalone.js

@@ -501,8 +501,8 @@ function StandAloneServer(gmeConfig) {
         __sessionStore,
         __workerManager,
         __users = {},
-        __googleAuthenticationSet = false,
-        __canCheckToken = true,
+        //__googleAuthenticationSet = false,
+        //__canCheckToken = true,
         __httpServer = null,
         __logoutUrl = gmeConfig.authentication.logOutUrl || '/',
         __baseDir = requireJS.s.contexts._.config.baseUrl,// TODO: this is ugly

src/server/util/ensureDir.js

@@ -6,11 +6,12 @@
  * @author https://github.com/samxxu/ensureDir
  */
 
+'use strict';
+
 var path = require('path'),
     fs = require('fs');
 
 function _ensureDir(dir, mode, callback) {
-    'use strict';
     var existsFunction = fs.exists || path.exists;
 
     existsFunction(dir, function (exists) {
@@ -53,13 +54,14 @@ function _ensureDir(dir, mode, callback) {
  */
 
 function ensureDir(dir, mode, callback) {
-    //jshint bitwise: false
     if (mode && typeof mode === 'function') {
         callback = mode;
         mode = null;
     }
 
-    mode = mode || 0777 & (~process.umask());
+    //jshint bitwise: false
+    mode = mode || parseInt('0777', 8) & (~process.umask());
+    //jshint bitwise: true
 
     callback = callback || function () {
     };

src/server/worker/serverworkermanager.js

@@ -1,4 +1,4 @@
-/*globals requireJS*/
+/*globals*/
 /*jshint node: true*/
 /**
  * @module Server:ServerWorkerManager

test-main.js

@@ -1,4 +1,4 @@
-/*globals require*/
+/*globals require, console*/
 /*jshint browser: true*/
 
 function done() {
@@ -12,7 +12,6 @@ function done() {
         };
 
     Object.keys(window.__karma__.files).forEach(function (file) {
-        'use strict';
         if (TEST_REGEXP.test(file)) {
             // Normalize paths to RequireJS module names.
             allTestFiles.push(pathToModule(file));
@@ -82,34 +81,36 @@ function done() {
     });
 }
 
-function httpGet(theUrl, callback) {
-    var xhr = new XMLHttpRequest();
-    console.log(theUrl);
-    xhr.open('GET', theUrl, true);
-    xhr.onreadystatechange  = function () {
-        console.log('ready state changed');
-        if (xhr.readyState === 4) {
-            if (xhr.status === 200) {
-                console.log(xhr.responseText);
-                callback(xhr.status);
-            } else {
-                console.error(xhr.statusText);
-                callback(xhr.status);
-            }
-        }
-    };
-    xhr.onerror = function (e) {
-        console.error(xhr.statusText);
-        callback(xhr.status);
-    };
-    xhr.send(null);
-    return xhr;
-}
+//function httpGet(theUrl, callback) {
+//    'use strict';
+//    var xhr = new XMLHttpRequest();
+//    console.log(theUrl);
+//    xhr.open('GET', theUrl, true);
+//    xhr.onreadystatechange  = function () {
+//        console.log('ready state changed');
+//        if (xhr.readyState === 4) {
+//            if (xhr.status === 200) {
+//                console.log(xhr.responseText);
+//                callback(xhr.status);
+//            } else {
+//                console.error(xhr.statusText);
+//                callback(xhr.status);
+//            }
+//        }
+//    };
+//    xhr.onerror = function (/*e*/) {
+//        console.error(xhr.statusText);
+//        callback(xhr.status);
+//    };
+//    xhr.send(null);
+//    return xhr;
+//}
 
 
 // FIXME: we should try to load gmeConfig with HTTPXmlRequest, to see if the server is up and running
 // wait for 5 seconds for server start up
 setTimeout(function () {
+    'use strict';
     done();
 }, 5000);
 

teststorage/teststorage.js

@@ -1,4 +1,4 @@
-/*globals define, alert*/
+/*globals define*/
 /*jshint browser: true*/
 /**
  * @author pmeijer / https://github.com/pmeijer

utils/build/empty/empty.js

@@ -1,3 +1,4 @@
+/*globals define*/
 define([], function () {
-   return;
+    'use strict';
 });

utils/build/webgme.classes/cbuild.js

@@ -22,4 +22,4 @@
     startFile: 'start.frag',
     endFile: 'end.frag'
   }
-})
+});