Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse french hunspell dictionary #108

Closed
gwen-lg opened this issue Jun 12, 2024 · 6 comments · Fixed by #109
Closed

Failed to parse french hunspell dictionary #108

gwen-lg opened this issue Jun 12, 2024 · 6 comments · Fixed by #109

Comments

@gwen-lg
Copy link
Contributor

gwen-lg commented Jun 12, 2024

In french dictionary, flags can have multiple characters.
Ex:
NEEDAFFIX () FORBIDDENWORD {} CIRCUMFIX ** KEEPCASE || NOSUGGEST --

and it's not correctly handeled

@gwen-lg gwen-lg changed the title FAiled to parse french hunspell dictionary Failed to parse french hunspell dictionary Jun 12, 2024
@tgross35
Copy link
Contributor

@gwen-lg I think I fixed the flag issue in #111. Any chance you could test with the French dictionary and see if you are getting reasonable results?

I'll release later today if it looks okay.

@gwen-lg
Copy link
Contributor Author

gwen-lg commented Jun 13, 2024

@tgross35 : yes, the build of dictionary work, and give reasonable results.
Thank you

@gwen-lg
Copy link
Contributor Author

gwen-lg commented Jun 13, 2024

Probably not related, but zspell seems not to recognize plurals and verb conjugations.

@tgross35
Copy link
Contributor

Thanks for confirming 👍 I'll get a release ready.

Do you have a specific example of plurals or conjugations? I suspect this probably needs lazy word checking (WIP...)

@gwen-lg
Copy link
Contributor Author

gwen-lg commented Jun 13, 2024

In the sentence : Même mourant, vous répondez présent.
the word répondez is detected as error, while it's a conjugation of the verb répondre
projections is not detected as plural of projection.

@tgross35
Copy link
Contributor

Thanks for the reproduction, I wrote that up in #116. It will unfortunately need a new feature.

The original issue should be fixed with the new release 0.5.5. I understand that unfortunately doesn't get far when there are no plurals :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants