From fe444475ba178a9202b047a15d76fca1d143b59d Mon Sep 17 00:00:00 2001
From: WhiteBlackGoose <wbg@angouri.org>
Date: Wed, 4 Aug 2021 18:59:53 +0300
Subject: [PATCH 1/2] Warnings suppressed ; warnings treated as errors

---
 src/Plotly.NET/CandelstickExtension.fs | 11 +++++++++++
 src/Plotly.NET/Chart.fs                | 10 ++++++++++
 src/Plotly.NET/Plotly.NET.fsproj       |  7 +++++++
 3 files changed, 28 insertions(+)

diff --git a/src/Plotly.NET/CandelstickExtension.fs b/src/Plotly.NET/CandelstickExtension.fs
index b5f6abf58..8e9c8266a 100644
--- a/src/Plotly.NET/CandelstickExtension.fs
+++ b/src/Plotly.NET/CandelstickExtension.fs
@@ -1,5 +1,16 @@
 namespace Plotly.NET
 
+
+// This disables FS0044, which is about using
+// obsolete API (marked with Obsolete attribute).
+//
+// It is needed because there are warnings coming
+// from the obsolete functions using obsolete API.
+//
+// However, it will hide using actually obsolete
+// API not used in obsolete API.
+#nowarn "44"
+
 open Trace
 open System
 open System.Runtime.InteropServices
diff --git a/src/Plotly.NET/Chart.fs b/src/Plotly.NET/Chart.fs
index eb607b1a9..5071a6ded 100644
--- a/src/Plotly.NET/Chart.fs
+++ b/src/Plotly.NET/Chart.fs
@@ -1,5 +1,15 @@
 namespace Plotly.NET
 
+// This disables FS0044, which is about using
+// obsolete API (marked with Obsolete attribute).
+//
+// It is needed because there are warnings coming
+// from the obsolete functions using obsolete API.
+//
+// However, it will hide using actually obsolete
+// API not used in obsolete API.
+#nowarn "44"
+
 open System
 open System.IO
 //open FSharp.Care.Collections
diff --git a/src/Plotly.NET/Plotly.NET.fsproj b/src/Plotly.NET/Plotly.NET.fsproj
index 5848525ee..1d81274f2 100644
--- a/src/Plotly.NET/Plotly.NET.fsproj
+++ b/src/Plotly.NET/Plotly.NET.fsproj
@@ -18,6 +18,12 @@
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
     <Configurations>Debug;Release;Dotnet</Configurations>
   </PropertyGroup>
+
+  <PropertyGroup>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsAsErrors />
+  </PropertyGroup>
+  
   <PropertyGroup>
     <Authors>Timo Mühlhaus, Kevin Schneider, F# open source contributors</Authors>
     <Description>plotly.js charts in .NET programming languages 📈🚀. </Description>
@@ -31,6 +37,7 @@
     <FsDocsLicenseLink>https://github.com/plotly/Plotly.NET/blob/dev/LICENSE</FsDocsLicenseLink>
     <FsDocsReleaseNotesLink>https://github.com/plotly/Plotly.NET/blob/dev/RELEASE_NOTES.md</FsDocsReleaseNotesLink>
   </PropertyGroup>
+  
   <ItemGroup>
     <None Include="..\..\docs\img\logo.png" Pack="true" PackagePath="\" />
     <Compile Include="AssemblyInfo.fs" />

From 826da216ba9cb37fddea1b89d863f0529a99f534 Mon Sep 17 00:00:00 2001
From: WhiteBlackGoose <wbg@angouri.org>
Date: Wed, 4 Aug 2021 19:07:34 +0300
Subject: [PATCH 2/2] TODOs added

---
 src/Plotly.NET/CandelstickExtension.fs | 5 +++++
 src/Plotly.NET/Chart.fs                | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/src/Plotly.NET/CandelstickExtension.fs b/src/Plotly.NET/CandelstickExtension.fs
index 8e9c8266a..f345272e1 100644
--- a/src/Plotly.NET/CandelstickExtension.fs
+++ b/src/Plotly.NET/CandelstickExtension.fs
@@ -9,6 +9,11 @@
 //
 // However, it will hide using actually obsolete
 // API not used in obsolete API.
+//
+// TODO: remove when 
+// https://github.com/fsharp/fslang-suggestions/issues/278 
+// or https://github.com/fsharp/fslang-suggestions/issues/1055
+// is implemented
 #nowarn "44"
 
 open Trace
diff --git a/src/Plotly.NET/Chart.fs b/src/Plotly.NET/Chart.fs
index 5071a6ded..c62b69b12 100644
--- a/src/Plotly.NET/Chart.fs
+++ b/src/Plotly.NET/Chart.fs
@@ -8,6 +8,11 @@ namespace Plotly.NET
 //
 // However, it will hide using actually obsolete
 // API not used in obsolete API.
+//
+// TODO: remove when 
+// https://github.com/fsharp/fslang-suggestions/issues/278 
+// or https://github.com/fsharp/fslang-suggestions/issues/1055
+// is implemented
 #nowarn "44"
 
 open System