From c31856fa00e82662ca62d7bdf7b01ba6046c0c04 Mon Sep 17 00:00:00 2001 From: manas-plivo Date: Tue, 4 Aug 2020 16:13:29 +0530 Subject: [PATCH 1/4] mms powerpack --- lib/plivo/resources/powerpacks.rb | 80 +++++++++++++++++++++++++++---- 1 file changed, 72 insertions(+), 8 deletions(-) diff --git a/lib/plivo/resources/powerpacks.rb b/lib/plivo/resources/powerpacks.rb index 25ce6959..0b6752aa 100644 --- a/lib/plivo/resources/powerpacks.rb +++ b/lib/plivo/resources/powerpacks.rb @@ -85,6 +85,10 @@ def list_numbers(options = nil) valid_param?(:type, options[:type], String, true) params[:type] = options[:type] end + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number', 'GET', params, true) end @@ -136,22 +140,46 @@ def count_numbers(options = nil) valid_param?(:type, options[:type], String, true) params[:type] = options[:type] end + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end response = perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number', 'GET', param, true) meta = response['meta'] return meta['total_count'] end - def find_number(number) + def find_number(number, options = nil) number_pool_uuid = getnumberpool_uuid(uuid) - perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + if options.nil? + perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , 'GET') + return + end + params = {} + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end + perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + 'GET', params) end - def add_number(number) + def add_number(number, options = nil) number_pool_uuid = getnumberpool_uuid(uuid) - perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + if options.nil? + perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , 'POST') + return + end + params = {} + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end + perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + 'POST', params) end def add_tollfree(tollfree) @@ -242,6 +270,10 @@ def buy_add_number(options = nil) number_pool_uuid = getnumberpool_uuid(uuid) params = {} params[:rent] = true + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end if options.key?(:number) return perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + options[:number].to_s , 'POST', params) @@ -360,6 +392,10 @@ def list(options = nil) valid_param?(:type, options[:type], String, true) params[:type] = options[:type] end + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number', 'GET', params, true) end @@ -401,20 +437,44 @@ def count(options = nil) valid_param?(:type, options[:type], String, true) params[:type] = options[:type] end + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end response = perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number', 'GET', params, true) meta = response['meta'] return meta['total_count'] end - def find(number) - perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + def find(number, options = nil) + if options.nil? + perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , 'GET') + return + end + params = {} + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end + perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + 'GET', params) end - def add(number) - perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + def add(number, options = nil) + if options.nil? + perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , 'POST') + return + end + params = {} + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end + perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + 'POST', params) end def remove(number, unrent= false) @@ -425,6 +485,10 @@ def remove(number, unrent= false) def buy_add_number(options = nil) params = {} params[:rent] = true + if options.key?(:service) && + valid_param?(:service, options[:service], String, true) + params[:service] = options[:service] + end if options.key?(:number) return perform_custom_action_apiresponse('NumberPool/' + number_pool_id + '/Number/' + options[:number].to_s , 'POST', params) From 720b282c0aff3232ac9cd136f87c531a274728fc Mon Sep 17 00:00:00 2001 From: manas-plivo Date: Thu, 6 Aug 2020 16:22:31 +0530 Subject: [PATCH 2/4] fix --- lib/plivo/resources/powerpacks.rb | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/plivo/resources/powerpacks.rb b/lib/plivo/resources/powerpacks.rb index 0b6752aa..2012287f 100644 --- a/lib/plivo/resources/powerpacks.rb +++ b/lib/plivo/resources/powerpacks.rb @@ -153,9 +153,8 @@ def count_numbers(options = nil) def find_number(number, options = nil) number_pool_uuid = getnumberpool_uuid(uuid) if options.nil? - perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + return perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , 'GET') - return end params = {} if options.key?(:service) && @@ -169,7 +168,7 @@ def find_number(number, options = nil) def add_number(number, options = nil) number_pool_uuid = getnumberpool_uuid(uuid) if options.nil? - perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , + return perform_custom_action_apiresponse('NumberPool/' + number_pool_uuid + '/Number/' + number.to_s , 'POST') return end @@ -449,9 +448,8 @@ def count(options = nil) def find(number, options = nil) if options.nil? - perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + return perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , 'GET') - return end params = {} if options.key?(:service) && @@ -464,9 +462,8 @@ def find(number, options = nil) def add(number, options = nil) if options.nil? - perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , + return perform_custom_action_apiresponse('NumberPool/' + @number_pool_id + '/Number/' + number.to_s , 'POST') - return end params = {} if options.key?(:service) && From c53643d37ebd9b005c643e579ef729dd0e68d064 Mon Sep 17 00:00:00 2001 From: manas-plivo Date: Tue, 25 Aug 2020 11:33:47 +0530 Subject: [PATCH 3/4] version updated --- CHANGELOG.md | 3 +++ README.md | 2 +- lib/plivo/version.rb | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a04ad02..8be226d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Change Log +## [4.9.0](https://github.com/plivo/plivo-ruby/releases/tag/v4.9.0) (2020-08-25) +- Powerpack for mms + ## [4.8.1](https://github.com/plivo/plivo-ruby/releases/tag/v4.8.1) (2020-06-05) - Fix Record a Conference API response. diff --git a/README.md b/README.md index 6304d076..4a7f7673 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a Add this line to your application's Gemfile: ```ruby -gem 'plivo', '>= 4.8.1' +gem 'plivo', '>= 4.9.0' ``` And then execute: diff --git a/lib/plivo/version.rb b/lib/plivo/version.rb index 9ac99268..6e9d5e89 100644 --- a/lib/plivo/version.rb +++ b/lib/plivo/version.rb @@ -1,3 +1,3 @@ module Plivo - VERSION = '4.8.1'.freeze + VERSION = '4.9.0'.freeze end From 80c76d9248ddb4b8ffd590c1e4369fa75aa49b09 Mon Sep 17 00:00:00 2001 From: nixonsam <37671608+nixonsam@users.noreply.github.com> Date: Mon, 7 Sep 2020 12:32:22 +0530 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf675774..25acbdb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Change Log ## [4.11.0](https://github.com/plivo/plivo-ruby/releases/tag/v4.9.0) (2020-08-25) -- Powerpack for mms +- Add Powerpack for mms ## [4.10.0](https://github.com/plivo/plivo-ruby/releases/tag/v4.10.0) (2020-09-04) - Add ConferenceUuid & CallState for Get Details of a Call API