From b6f76f9cf474fc4a8b21a0bffab481e5ace5d27a Mon Sep 17 00:00:00 2001 From: narayana Date: Wed, 16 Aug 2023 15:58:42 +0530 Subject: [PATCH] adding new param on mdr object --- CHANGELOG.md | 4 ++++ lib/resources/messages.js | 7 ++++++- lib/rest/request-test.js | 15 ++++++++++++--- package.json | 2 +- test/messages.js | 6 ++++++ 5 files changed, 29 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70822654..73f4dbfd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change Log +## [v4.56.0](https://github.com/plivo/plivo-go/tree/v4.56.0) (2023-08-16) +**Feature - Added New Param 'carrier_fees', 'carrier_fees_rate', 'destination_network' in Get Message and List Message APIs** +- Added new params on message get and list response + ## [v4.55.0](https://github.com/plivo/plivo-node/tree/v4.55.0) (2023-08-10) **Verify Service API's** - Create Session API - To initiate a session diff --git a/lib/resources/messages.js b/lib/resources/messages.js index 7c914e8d..d33314e9 100644 --- a/lib/resources/messages.js +++ b/lib/resources/messages.js @@ -59,7 +59,9 @@ export class MessageGetResponse { this.dltEntityID = params.dltEntityId; this.dltTemplateID = params.dltTemplateId; this.dltTemplateCategory = params.dltTemplateCategory; - + this.destinationNetwork = params.destinationNetwork; + this.carrierFees = params.carrierFees; + this.carrierFeesRate = params.carrierFeesRate; } } @@ -91,6 +93,9 @@ export class MessageListResponse { this.dltEntityID = params.dltEntityId; this.dltTemplateID = params.dltTemplateId; this.dltTemplateCategory = params.dltTemplateCategory; + this.destinationNetwork = params.destinationNetwork; + this.carrierFees = params.carrierFees; + this.carrierFeesRate = params.carrierFeesRate; } } diff --git a/lib/rest/request-test.js b/lib/rest/request-test.js index cf20f6b4..c23cad18 100644 --- a/lib/rest/request-test.js +++ b/lib/rest/request-test.js @@ -2170,7 +2170,10 @@ export function Request(config) { dlt_template_category: "transactional", conversation_id: "1234", conversation_origin: "service", - conversation_expiration_timestamp: "2023-08-03 23:02:00+05:30" + conversation_expiration_timestamp: "2023-08-03 23:02:00+05:30", + destination_network: "Verizon", + carrier_fees_rate: "0.420", + carrier_fees: "0.001" } }); } @@ -2206,7 +2209,10 @@ export function Request(config) { dlt_template_category: "service_implicit", conversation_id: "9876", conversation_origin: "marketing", - conversation_expiration_timestamp: "2023-08-03 23:02:00+05:30" + conversation_expiration_timestamp: "2023-08-03 23:02:00+05:30", + destination_network: "Verizon", + carrier_fees_rate: "0.420", + carrier_fees: "0.001" }, { @@ -2229,7 +2235,10 @@ export function Request(config) { dlt_template_category: null, conversation_id: null, conversation_origin: null, - conversation_expiration_timestamp: null + conversation_expiration_timestamp: null, + destination_network: "Verizon", + carrier_fees_rate: "0.420", + carrier_fees: "0.001" } ] } diff --git a/package.json b/package.json index 9e4a1008..86abd8f2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.55.0", + "version": "4.56.0", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ diff --git a/test/messages.js b/test/messages.js index ff872258..5aabc3f0 100644 --- a/test/messages.js +++ b/test/messages.js @@ -40,6 +40,12 @@ describe('message', function () { assert.equal(message.conversationExpirationTimestamp, "2023-08-03 23:02:00+05:30"); }) }); + it('should have destination network parameter in get message', function () { + return client.messages.get(1) + .then(function (message) { + assert.equal(message.destinationNetwork, "Verizon"); + }) + }); it('list messages', function () { return client.messages.list() .then(function (messages) {