From bf028f2315b810549f3385104c84c04a0327d051 Mon Sep 17 00:00:00 2001 From: narayana Date: Tue, 7 Dec 2021 10:10:07 +0530 Subject: [PATCH 1/4] customer issue fix --- CHANGELOG.md | 4 ++++ lib/rest/axios.js | 8 ++++---- package.json | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e446d073..cd08092e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change Log + +## [v4.25.1](https://github.com/plivo/plivo-node/tree/v4.25.1) (2021-12-07) +- response undefined fix and timeout removed for messaging. + ## [v4.25.0](https://github.com/plivo/plivo-node/tree/v4.25.0) (2021-12-02) **Features - Messaging: 10DLC API** - 10DLC API's for brand and campaign support diff --git a/lib/rest/axios.js b/lib/rest/axios.js index c927ed5c..55045924 100644 --- a/lib/rest/axios.js +++ b/lib/rest/axios.js @@ -96,7 +96,7 @@ export function Axios(config) { .catch(function (error) { //client side exception like file not found case if (error.response == undefined){ - reject(error.stack ); + return reject(error.stack ); } const exceptionClass = { 400: Exceptions.InvalidRequestError, @@ -175,7 +175,7 @@ export function Axios(config) { if (typeof config.timeout !== 'undefined') { options.timeout = config.timeout; } - else if(typeof config.timeout === 'undefined'){ + else if(typeof config.timeout === 'undefined' && isVoiceReq ){ options.timeout = 5000; } @@ -212,7 +212,7 @@ export function Axios(config) { }) .catch(function (error) { if (error.response == undefined){ - reject(error.stack ); + return reject(error.stack ); } const exceptionClass = { 400: Exceptions.InvalidRequestError, @@ -268,7 +268,7 @@ export function Axios(config) { }) .catch(function (error) { if (error.response == undefined){ - reject(error.stack ); + return reject(error.stack ); } const exceptionClass = { 400: Exceptions.InvalidRequestError, diff --git a/package.json b/package.json index c15b9f56..bc3291eb 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "plivo", - "version": "4.25.0", + "version": "4.25.1", "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML", "homepage": "https://github.com/plivo/plivo-node", "files": [ From c584640b3bcb7ed9e398fa90bfdd8a0bb47ffa6f Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 8 Dec 2021 10:34:27 +0530 Subject: [PATCH 2/4] updated changelog --- CHANGELOG.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cd08092e..6ebc6e1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # Change Log - -## [v4.25.1](https://github.com/plivo/plivo-node/tree/v4.25.1) (2021-12-07) -- response undefined fix and timeout removed for messaging. +## [v4.25.1](https://github.com/plivo/plivo-node/tree/v4.25.1) (2021-12-08) +**Bug Fix** +- `undefined response` error from the library axios. +- Timeout has been eliminated for messaging requests. ## [v4.25.0](https://github.com/plivo/plivo-node/tree/v4.25.0) (2021-12-02) **Features - Messaging: 10DLC API** From 6599cc761b8ed361cf7d6260b844ea36aa3dce49 Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 8 Dec 2021 10:40:37 +0530 Subject: [PATCH 3/4] updated changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ebc6e1c..bd38ec89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## [v4.25.1](https://github.com/plivo/plivo-node/tree/v4.25.1) (2021-12-08) **Bug Fix** -- `undefined response` error from the library axios. +- Handing `undefined response` error from axios. - Timeout has been eliminated for messaging requests. ## [v4.25.0](https://github.com/plivo/plivo-node/tree/v4.25.0) (2021-12-02) From fc5eae05da608f2f645135df1c4e1888003eabbb Mon Sep 17 00:00:00 2001 From: huzaif-plivo Date: Wed, 8 Dec 2021 10:42:31 +0530 Subject: [PATCH 4/4] updated changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bd38ec89..cd2f2450 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## [v4.25.1](https://github.com/plivo/plivo-node/tree/v4.25.1) (2021-12-08) **Bug Fix** -- Handing `undefined response` error from axios. +- Handling `undefined response` error from axios. - Timeout has been eliminated for messaging requests. ## [v4.25.0](https://github.com/plivo/plivo-node/tree/v4.25.0) (2021-12-02)