Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverpassLayer extend Layer #22

Open
xeruf opened this issue Oct 5, 2022 · 2 comments
Open

OverpassLayer extend Layer #22

xeruf opened this issue Oct 5, 2022 · 2 comments

Comments

@xeruf
Copy link
Contributor

xeruf commented Oct 5, 2022

It seems like quite a bit of functionality is reimplemented as it does not seem to extend the inbuilt Leaflet Layer, and functions such as removeFrom are missing:
https://leafletjs.com/reference.html#layer

Are these sublayers something internal or also externally usable?

@xeruf
Copy link
Contributor Author

xeruf commented Oct 5, 2022

Is there an event that is triggered when a layer is hidden because of the zoom level?

@plepe
Copy link
Owner

plepe commented Oct 5, 2022

Hmm, when I started overpass-layer I just made a class and later I adapted it, to work as a Leaflet layer, but with minimal effort. I guess, this was wrong ;-) If you want to convert it to a real Leaflet layer, you are welcome to do so.

No, if I remember correctly, the Sublayers are only internally. Currently, there's no event which gets emitted, when the layer is hidden due to the zoom level, but it should be easy to add (Sublayer.hideAll).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants