New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wenv init should fail when get-pip.py fails #23

Open

milahu opened this issue Apr 16, 2024 · 1 comment

Labels

bug

milahu commented Apr 16, 2024

this should throw when get-pip.py fails

wenv/_core/env.py

        if self._p["offline"]:
            proc = subprocess.Popen(
                [
                    "wenv",
                    "python",
                    os.path.join(self._p["cache"], "get-pip.py"),
                    "--no-index",
                    "--find-links=%s" % self._p["packages"],
                ],
                env=envvar_dict,
            )
            proc.wait()

usually i do this with

args = [
  "wenv",
  "python",
  # ...
]

subprocess.run(
  args,
  check=True,
)

s-m-e added the bug label

Member

s-m-e commented Apr 17, 2024

Thx, most certainly a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment