Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Webhooks properly if pervious is still being handled #2

Closed
nleanba opened this issue Mar 9, 2024 · 3 comments · Fixed by #3
Closed

Accept Webhooks properly if pervious is still being handled #2

nleanba opened this issue Mar 9, 2024 · 3 comments · Fixed by #3
Assignees

Comments

@nleanba
Copy link
Collaborator

nleanba commented Mar 9, 2024

Currently, it seems that it doesn't acknowledge incoming web hooks if it is still busy handling a previous one, leading to the proxy (traefik?) to report a 504.

This makes it hard to distinguish between a web hook that did not arrive and one that just didnt get acknowledged.

@nleanba nleanba self-assigned this Mar 9, 2024
@retog
Copy link
Collaborator

retog commented Mar 18, 2024

I don't think the second works, as github would probably close the connection.

@nleanba
Copy link
Collaborator Author

nleanba commented Mar 18, 2024

if github closes the connection there isn't much we can do; it is at worst no change to status quo.

@retog
Copy link
Collaborator

retog commented Mar 19, 2024

I don't see the rationale for having things different than in gg2rdf.

@nleanba nleanba linked a pull request May 13, 2024 that will close this issue
@retog retog closed this as completed in #3 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants