-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express break server #6
Comments
I just ran all the tests using Express 4.11.1 and I'm not seeing any errors, was this resolved upstream since zentuit's source which uses 4.10.4? Are you able to reproduce the issue with 4.11.1? |
Retried with the latest GIT version:
createServer has been deprecated in 4, it should be
There is a few other quirks that has been fixed in zentuit's source. |
I don't have an ETA but @zentuit just got back to me by email and said he can do a pull request after he finishes up some stuff. |
Pull request sent. Ben - the tests will all pass since they are just testing the api, not the node server (express) underneath. I haven't added any tests for web.js (and router.js). That would probably be a good idea. |
Package says to use Express 4 but this doesn't works.
Might I suggest using: https://github.com/zentuit/apiserver/commits/master fixes
The text was updated successfully, but these errors were encountered: