Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create split dividers/<hr>s #328

Closed
erictheise opened this issue Apr 28, 2020 · 3 comments · Fixed by #344
Closed

Create split dividers/<hr>s #328

erictheise opened this issue Apr 28, 2020 · 3 comments · Fixed by #344
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@erictheise
Copy link
Member

Is your feature request related to a problem? Please describe.

The mock up for the login page includes what appears to be a Pinecone Divider split in two with text in the center. It divides the action of logging in with a system account from logging in using a third party and contains the word OR between Dividers.

Describe the solution you'd like

Pinecone folks deciding what's best and providing

  1. a Split Divider Atom in Pinecone whose options match the colors and vertical thickness of regular Dividers or
  2. the css needed to vertically align two regular Dividers and horizontally center text between them or
  3. html and the css to match the mock.

Describe alternatives you've considered

Mucking around with spans and/or display myself.

Additional context

iPhone Login

@greatislander
Copy link
Collaborator

@dayotte Can you give me some text specifications for this? I can make the component pretty quickly as soon as I know what you have in mind for typography.

@dayotte
Copy link

dayotte commented Apr 29, 2020

@greatislander I discussed with @cherylhjli and have followed the type stack specs from the component library, you'll see the updated mobile & desktop mockups in the Account Log in / Sign up page in the Figma file here https://www.figma.com/file/tXFtpKPWuGUFrotFsXshZq/Directory-Wireframes_DA?node-id=978%3A56
Does this give you enough or do you need more/other from me?

@greatislander
Copy link
Collaborator

This is perfect, thank you @dayotte!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants