Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 🍌 , I use the gem with Heroku and they deprecated elasticsearch 6.X from their add-on stack. This PR allows the gem to use ElasticSearch 7+. Changes that needed to be done are:
disabled_cord
option has been deprecated since elasticsearch 6.x but, the parameter was ignored... now the parameter throws an exception so it had to be removed. With this changecoord_similarity
config didn't make sense so it was removed as well.include_type_name
defaulted totrue
, now on elasticsearch 7.X it defaults tofalse
":"
is not allowed on index names. index names now uses only"_"
for word/timestamp separationtotal
property for the hits changed it's schema from:to:
Note: if you want to read all the breaking changes they are here
Hope this PR is well received and become useful for someone else!
This PR also resolves #10