Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of elasticsearch 7 #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mihailpozarski
Copy link

@mihailpozarski mihailpozarski commented Jun 6, 2022

Hi 🍌 , I use the gem with Heroku and they deprecated elasticsearch 6.X from their add-on stack. This PR allows the gem to use ElasticSearch 7+. Changes that needed to be done are:

  • The disabled_cord option has been deprecated since elasticsearch 6.x but, the parameter was ignored... now the parameter throws an exception so it had to be removed. With this change coord_similarity config didn't make sense so it was removed as well.
  • Typed APIs has been deprecated and replaced with Typless APIs as described here. So any type used on mapping and bulk ops has been removed.
  • On elasticsearch 6.X include_type_name defaulted to true, now on elasticsearch 7.X it defaults to false
  • From elasticsearch 7+ the special character ":" is not allowed on index names. index names now uses only "_" for word/timestamp separation
  • Finally, the search API total property for the hits changed it's schema from:
    Captura de Pantalla 2022-06-06 a la(s) 12 07 14
    to:
    Captura de Pantalla 2022-06-06 a la(s) 12 07 06

Note: if you want to read all the breaking changes they are here

Hope this PR is well received and become useful for someone else!

This PR also resolves #10

@mihailpozarski mihailpozarski marked this pull request as ready for review June 6, 2022 20:34
@rjherrera rjherrera requested a review from iobaixas June 6, 2022 21:44
@mihailpozarski
Copy link
Author

Hi! @rjherrera can you help me get some love from @iobaixas?

This PR is starting to feel lonely 😢

@mihailpozarski
Copy link
Author

😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Colon in index name is now deprecated
1 participant