-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Follows Service iOS] Tapping on a follows notification opens the profile of the person who followed you #1447
Comments
@mplorentz I've been thinking about changing the message payload to make it easier to bundle multiple followers. I plan to update the payload to include two arrays of objects containing I'll use this new payload for single-follower notifications as well, including the friendly ID in the text. For aggregations, the text will just show follow/unfollow counts, but both will use the same payload. |
@mplorentz I think I unblock you with this PR planetary-social/nos-notification-service-go#64 |
added routing to profile when tapping on follow notification #1447
@bryanmontz - The AC for this said to open the profile for the user. Instead I'm taken to the Notifications tab. See video https://github.com/user-attachments/assets/48122bb5-4865-4cf4-9179-a82e574a6905 |
@setch-l What build was that on? Are you 100% sure that the code for this was part of that build? I'm asking bc in the video it doesn't look like anything happens at all as a result of tapping the notification. It works for me, both in the simulator and in the latest TestFlight build (0.1.27 (278)), even when the side menu is open while the app is backgrounded like yours was in the video. Here's a video from my device. I cut it off before it loaded everything, but it did eventually load the profile and some notes. |
Hey Bryan that was done on my phone. I’m on 279 right now. I don’t recall
if yesterday it was with 278, maybe a regression ?
…On Sat, 28 Sep 2024 at 10:08 Bryan Montz ***@***.***> wrote:
@setch-l <https://github.com/setch-l> What build was that on? Are you
100% sure that the code for this was part of that build? I'm asking bc in
the video it doesn't look like anything happens at all as a result of
tapping the notification. It works for me, both in the simulator and in the
latest TestFlight build (0.1.27 (278)), even when the side menu is open
while the app is backgrounded like yours was in the video. Here's a video
from my device. I cut it off before it loaded everything, but it did
eventually load the profile and some notes.
push-profile.gif (view on web)
<https://github.com/user-attachments/assets/19e071a2-d95d-4234-bb17-c266276df56e>
—
Reply to this email directly, view it on GitHub
<#1447 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEOCD6YHY6OKW45OF7GH3ZY2S4VAVCNFSM6AAAAABNM3PXZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBQGYZTINZRHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Given that I am a user of Nos
When I tap on a follow notification
Then it should open the profile of the person who followed my account
Notes from Daniel:
Read notification metadata so that tapping on it opens the correct profile (iOS team)
The text was updated successfully, but these errors were encountered: