Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follows Service iOS] Tapping on a follows notification opens the profile of the person who followed you #1447

Open
setch-l opened this issue Aug 30, 2024 · 5 comments
Assignees

Comments

@setch-l
Copy link

setch-l commented Aug 30, 2024

Given that I am a user of Nos
When I tap on a follow notification
Then it should open the profile of the person who followed my account

Notes from Daniel:
Read notification metadata so that tapping on it opens the correct profile (iOS team)

@dcadenas
Copy link
Contributor

@mplorentz I've been thinking about changing the message payload to make it easier to bundle multiple followers. I plan to update the payload to include two arrays of objects containing npubs, one for follows and one for unfollows. This is pending work, so it might be best to wait until it's done, but there may be tasks you can start on now. It's on my task list here.

I'll use this new payload for single-follower notifications as well, including the friendly ID in the text. For aggregations, the text will just show follow/unfollow counts, but both will use the same payload.

@dcadenas
Copy link
Contributor

@mplorentz I think I unblock you with this PR planetary-social/nos-notification-service-go#64

@setch-l
Copy link
Author

setch-l commented Sep 24, 2024

@bryanmontz - The AC for this said to open the profile for the user. Instead I'm taken to the Notifications tab.

See video https://github.com/user-attachments/assets/48122bb5-4865-4cf4-9179-a82e574a6905

@bryanmontz
Copy link
Contributor

@setch-l What build was that on? Are you 100% sure that the code for this was part of that build? I'm asking bc in the video it doesn't look like anything happens at all as a result of tapping the notification. It works for me, both in the simulator and in the latest TestFlight build (0.1.27 (278)), even when the side menu is open while the app is backgrounded like yours was in the video. Here's a video from my device. I cut it off before it loaded everything, but it did eventually load the profile and some notes.

push-profile

@dcadenas
Copy link
Contributor

dcadenas commented Sep 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint
Development

No branches or pull requests

4 participants