Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lists] Add the client marker to contact lists #51

Closed
setch-l opened this issue Aug 13, 2024 · 2 comments
Closed

[Lists] Add the client marker to contact lists #51

setch-l opened this issue Aug 13, 2024 · 2 comments
Assignees

Comments

@setch-l
Copy link

setch-l commented Aug 13, 2024

Overview
For troubleshooting purposes it would be helpful to know on which client an update to the contact list occurred. This will help us measure whether Nos is overwriting contact lists or if it's some other app. NIP-89 has a spec for a "Client Tag" that we can use.

AC:

  • Add the client marker to each content and account flag posted from Nos to say that it came from Nos.
@mplorentz mplorentz changed the title [Moderation] Add the client marker to moderation flags [Lists] Add the client marker to contact lists Sep 24, 2024
@mplorentz
Copy link
Member

From our meeting today: closing as a dupe of planetary-social/nos#1455 (even though the title was talking about moderation, this was supposed to be about contact lists)

@setch-l setch-l assigned mplorentz and unassigned dcadenas Sep 24, 2024
@mplorentz
Copy link
Member

It occurred to me while implementing this that once we publish a contact list with the Nos tag, other Nostr apps may preserve that tag when they publish new versions of the list.

To mitigate this I added code to fire a new "Published Contact List" analytics event as well. Now if our server-side alert goes off we can check Posthog to verify whether the event that overwrote the contact list was actually published by Nos or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants