Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel All builds button for Development Ministry #128

Closed
RedOrion opened this issue Dec 2, 2015 · 10 comments
Closed

Cancel All builds button for Development Ministry #128

RedOrion opened this issue Dec 2, 2015 · 10 comments

Comments

@RedOrion
Copy link
Member

RedOrion commented Dec 2, 2015

No description provided.

@nataliethistime
Copy link
Contributor

👍

@Fogghorn
Copy link

I'd prefer a select all option similar to the email inbox. That way I could deselect any that I wish to leave in the queue. For example I often want to leave the top item in the queue as it is partially completed and just want to cancel the rest of the queue.

@RedOrion
Copy link
Member Author

👍

@nataliethistime
Copy link
Contributor

I quite like that. 👍

@dmcbride
Copy link
Contributor

So the first bit here, then, is to see if we can have a delete_many_from_queue API on the server for the web client to call.

The other fun bit is to return the newly-updated queue and repopulate the queue list in the UI with that.

I suspect this is best left until we start to reactify the building panels.

@nataliethistime
Copy link
Contributor

@dmcbride Agreed. I'd only want to make large changes to the code if it helps the effort to move to React. So, implementing new features on the old code is a no. That then means that I should figure out how to do that. I suspect there's a bit to it. I'll look into it...

@nataliethistime
Copy link
Contributor

See: #146

@nataliethistime
Copy link
Contributor

@dmcbride This should get closed. 🎅

@dmcbride
Copy link
Contributor

dmcbride commented Feb 3, 2016

@1vasari what's still missing here is the "select which ones I want to cancel somehow" - the API now will allow multiple IDs being passed in at the same time, but the client doesn't offer that to the user yet.

@nataliethistime
Copy link
Contributor

@dmcbride We'll Reactify the Dev min, one day. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants