Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores description should be updated #1462

Closed
Latimew333 opened this issue Jul 20, 2023 · 7 comments · Fixed by #1467
Closed

Underscores description should be updated #1462

Latimew333 opened this issue Jul 20, 2023 · 7 comments · Fixed by #1467

Comments

@Latimew333
Copy link
Contributor

Location is 480,734. The current description deadnames and misgenders underscores, it should be changed to read "underscores, real name April Harper Grey, is an American EDM/hyperpop music producer, born in California and based in New York. She is also a member of the group Six Impala."

@Codixer
Copy link
Member

Codixer commented Jul 21, 2023

You're able to edit it on https://2023.place-atlas.stefanocoding.me/ if you want, most/almost all entries go through Reddit/GitHub for anyone to see. Make sure to read https://github.com/placeAtlas/atlas-2023/blob/master/CONTRIBUTING.md before you do.

@Hans5958 Hans5958 linked a pull request Jul 21, 2023 that will close this issue
@Hans5958
Copy link
Member

Hans5958 commented Jul 21, 2023

I will keep this open. Don't worry, it is a valid issue, and should be closed when it is resolved. (Yeah, it is not needed, but since you did it already...)


You're able to edit it on 2023.place-atlas.stefanocoding.me if you want...

This is 2022

@Hans5958 Hans5958 reopened this Jul 21, 2023
@Latimew333
Copy link
Contributor Author

hey this was closed awhile ago but it still hasn't moved from cleanup to the main branch, how long should it take for that to happen?

@Latimew333
Copy link
Contributor Author

I can't even see the patch in cleanup anymore so I'm not sure if the change wasn't lost or something

@Latimew333
Copy link
Contributor Author

yeah looking at atlas.json in the cleanup branch it still has the old description so it looks like it was just never actually applied or something? Can this be reopened until it's actually fixed?

@Hans5958
Copy link
Member

That's weird. The PR should have been merged and the changes have been incorporated. I have recreated the patch on #1485 but I'll have take a closer look on it.

@Hans5958
Copy link
Member

I found the culprit. #1479 removed the patch before it got implemented on the main data.

@Hans5958 Hans5958 reopened this Aug 12, 2023
@Hans5958 Hans5958 linked a pull request Aug 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants