Skip to content

Commit 61f62c8

Browse files
committed
fix: build warning in useDataset.ts
- always use the global dataset object rather than local state. - remove a debugging log.
1 parent 502b27c commit 61f62c8

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

frontend-v2/src/features/trial/Protocols.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ const Protocols: FC = () => {
4949
);
5050

5151
const { dataset } = useDataset(selectedProject);
52-
console.log('trials', dataset)
5352

5453
const loading = [isProjectLoading, isProtocolsLoading, unitsLoading].some(
5554
(x) => x,

frontend-v2/src/hooks/useDataset.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ export default function useDataset(selectedProject: number | null) {
1919
createDataset
2020
] = useDatasetCreateMutation();
2121

22+
if (dataset !== appDataset) {
23+
setDataset(appDataset);
24+
}
25+
2226
useEffect(function onDataLoad() {
2327
async function addDataset() {
2428
let [newDataset] = datasets;
@@ -34,7 +38,7 @@ export default function useDataset(selectedProject: number | null) {
3438
}
3539
}
3640
appDataset = newDataset;
37-
setDataset(newDataset);
41+
setDataset(appDataset);
3842
}
3943
if (selectedProjectOrZero && !isDatasetLoading) {
4044
addDataset();
@@ -43,11 +47,11 @@ export default function useDataset(selectedProject: number | null) {
4347

4448
const updateDataset = useCallback((newDataset: DatasetRead) => {
4549
appDataset = newDataset;
46-
setDataset(newDataset);
50+
setDataset(appDataset);
4751
}, []);
4852

4953
return {
50-
dataset: appDataset,
54+
dataset,
5155
updateDataset
5256
};
5357
}

0 commit comments

Comments
 (0)