Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a new context in a different language, required metadata is not flagged #10908

Open
Tribunal33 opened this issue Feb 7, 2025 · 1 comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@Tribunal33
Copy link

Tribunal33 commented Feb 7, 2025

Describe the bug
While creating another journal in a French language the workflow throws errors which make it difficult for a user to complete.

To Reproduce
Steps to reproduce the behavior:

  1. Login as Admin (with the user's language set to English)
  2. Select Administration from dropdown
  3. Under Site Management select Hosted journals button
  4. Select Create Journal to open New journal form
  5. Fill in the form fields
    a. Journal Title = "This is a french journal"
    b. Journal Initials = "Fr"
    c. Journal Abbreviation = "FrenchJ"
    d. Principal Contact Name = "Frenchj"
    e. Principal Contact Email = "[email protected]"
    f. Country = "France" from dropdown
    h. Journal Description = "This is a french description"
    i. Path = add "frenchj" to end
    j. Important Languages choose both English and French options
    k. important Primary local choose French option
    l. Enabled = check this box
  6. Then click Save button when done (No warnings given here even though french language fields were not filled in)
  7. It will open up the Settings Wizard (For simplicity) just select Save again
  8. Error message will show up in top right corner and message will say "Please correct one error. Jump to next error" but no error is seen
  9. Select "Jump to next error" link

Expected : There shouldn't be any errors or they should be addressed earlier.

Actual : It redirects to a hidden form with field titles that just say "French" and the Warning message is in English. This happens on 3.4 too but the message is in French. Even if you fill in all the form fields correctly and save, the "edit" option for the newly created French journal does share the same fields as an english created one. It is difficult to know what the requirements are for this but it is unintuitive for the user. I will try to highlight all the problems in a video.

Additional information

Video : failed to upload but I have a full video of the error

Image

Image

@Tribunal33 Tribunal33 added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Feb 7, 2025
@Tribunal33 Tribunal33 added this to the 3.5.0 LTS milestone Feb 7, 2025
@kaitlinnewson kaitlinnewson changed the title Site Wide Context - Create new hosted journal in another supported language throws several errors When creating a new context in a different language, missing metadata is not flagged Feb 10, 2025
@kaitlinnewson kaitlinnewson changed the title When creating a new context in a different language, missing metadata is not flagged When creating a new context in a different language, required metadata is not flagged Feb 10, 2025
@kaitlinnewson
Copy link
Member

kaitlinnewson commented Feb 10, 2025

Issue confirmed starting in 3.3 as well. There are a few elements to this issue:

  • The form fields only appear in English if the user's language is set to English, so the issue appears when there is a mismatch between the user's locale and the primary locale the new context is using
  • You can create a new context in a different locale from the user's language, but the fields for that locale won't appear by default unless opened in the UI during the initial creation of the context
  • You can save the new context without filling in the required fields for the primary locale of that context, leading to errors later
  • Later in the process, the forms become confusing partially because the setting to show English for forms is disabled by default

So we need to check that the required fields for the journal in the journal's primary locale have been entered to avoid the issues after the initial creation form is saved.

@kaitlinnewson kaitlinnewson added Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. and removed Bug:2:Moderate A bug that is causing problems for a substantial minority of users. labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

2 participants