Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert controlled vocabulary classes to Eloquent models #10292

Closed
asmecher opened this issue Aug 8, 2024 · 11 comments
Closed

Convert controlled vocabulary classes to Eloquent models #10292

asmecher opened this issue Aug 8, 2024 · 11 comments
Assignees
@touhidurabir
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@asmecher
Copy link
Member

asmecher commented Aug 8, 2024 •
edited by touhidurabir
Loading

There are several classes that use the old DAO storage model to handle controlled vocabularies and related code:

  • controlled_vocab_entries and controlled_vocab_entry_settings (these will require a trait for settings tables, which @Vitaliy-1 is working on)
  • controlled_vocabs
  • user_interests

In preparation for extensions to the controlled vocabulary toolset in support of vocabulary plugins that implement specific vocabs (e.g. LCSH etc), the storage model for these tables should be migrated to Eloquent.

PRs
pkp-lib --> #10324
ojs --> pkp/ojs#4403
omp --> pkp/omp#1722
ops --> pkp/ops#788
citationStyleLanguage --> pkp/citationStyleLanguage#127
jatsTemplate --> pkp/jatsTemplate#54
oaiJats --> pkp/oaiJats#51
reviewReport --> pkp/reviewReport#52
@asmecher asmecher added this to the 3.5.0 LTS milestone Aug 8, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
e9c27fc
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
9375230
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
852c673
This was referenced Aug 16, 2024
Merged
Merged
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
d1e3e38
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
85bf407
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
a9d82cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ae25aff
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
a581dc9
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
5db03d3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
09dbd87
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 typo fixed
12072a7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2055e6d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
5cefa04
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
20fefd2
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
dd868ac
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
8b5d705
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 typo fixed
15f9263
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
4845517
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ff4e8f7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
80cd267
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
22f3d1c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
a8b8438
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 added user_interests primary key migration
c40165b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 fixed user_interests primary key migration path
46d784e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 fixing unit tests
1463f2d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c517c8b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 user interest assoc const refactor
6c036eb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 controlled vocabs assoc id nullable
d4ff9c3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 migrated controlled vocabs setting name from symbol…
71ad353 
…ics to name
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
65c725e
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
8e0e42e
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
b4daf3c
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
e054636
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
f141025
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
8ac8690
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 user interest vocab const added
fea9d7f
touhidurabir added a commit to touhidurabir/omp that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 vocab assoc id nullable and setting anme update for…
693c49f 
…m symbolic to name
touhidurabir added a commit to touhidurabir/ops that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
a2f484c
touhidurabir added a commit to touhidurabir/ops that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
d1d465d
touhidurabir added a commit to touhidurabir/ops that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
e962d6a
touhidurabir added a commit to touhidurabir/ops that referenced this issue Dec 21, 2024
@touhidurabir
pkp/pkp-lib#10292 vocab assoc id nullable and setting anme update for…
640b028 
…m symbolic to name
@touhidurabir touhidurabir mentioned this issue Dec 31, 2024
Merged
@touhidurabir
Copy link
Member

@asmecher please take a final look at PRs at #10292 (comment) .

asmecher pushed a commit to pkp/reviewReport that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 Controlled vocab dao to eloquent model
613059b
asmecher pushed a commit to pkp/oaiJats that referenced this issue Jan 4, 2025
@touhidurabir
pkp/pkp-lib#10292 Controlled vocab dao to eloquent model (#51)
8dd7701 
* pkp/pkp-lib#10292 Controlled vocab dao to eloquent model

* pkp/pkp-lib#10292 removed extended vocab classes
asmecher pushed a commit to pkp/jatsTemplate that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 Controlled vocab dao to eloquent model
053156b
asmecher pushed a commit to pkp/jatsTemplate that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 removed extended vocab classes
71f3202
asmecher pushed a commit to pkp/jatsTemplate that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 removed PHPUnit deprecations
efae8c7
asmecher pushed a commit to pkp/jatsTemplate that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 test fix and test namespace updated to psr-4
412e100
asmecher added a commit to pkp/citationStyleLanguage that referenced this issue Jan 4, 2025
@asmecher
Merge pull request #127 from touhidurabir/i10292_main
d16ff65 
pkp/pkp-lib#10292 Controlled vocab dao to eloquent model
asmecher pushed a commit that referenced this issue Jan 4, 2025
@touhidurabir
#10292 Controlled Vocab DAO to Eloquent Model (#10324)
025a6fc 
* #10292 Controlled Vocab DAO to Eloquent Model

* #10292 WIP: Controlled Vocab DAO to Eloquent Model

* #10292 typo fixed

* #10292 proper model import for native xml

* #10292 fixing unit tests

* #10292 Refactored user interest to model and repository

* #10292 removed extended vocab classes

* #10292 fixing issue with vocab storing and some doc blocks added

* #10292 added TODO to investigate the impact of merged issue #10423 PR

* #10292 refactored entry dao to model class

* #10292 removed setting_type column

* #10292 fixed vocab setting issue

* #10292 refactored interest manager to repo and removed it

* #10292 resolved all but one TODO

* #10292 fixed issue the settings builder to retrieve specific columns only

* #10292 fixed issue when guarded attribute defined

* #10292 updated implementation of updating with multilingual data

* #10292 added multilingual casting as part of #10476

* #10292 fixed issue the data building with settings attrs

* #10292 updated setting builder to work with non schema based entity

* #10292 allow nullable locales to be passed to repo method getBySymbolic

* #10292 updated to handle context based query

* #10292 make context id required on controlled vocabs operations

* #10292 update mistaken test modification

* #10292 sub query update for locale and setting value search

* #10292 revert back context id direct addition to vocabs

* #10292 fixing symbolics and settings name mixing confusion

* #10292 fixed issue with user interest and multilingual data update through cast

* #10292 controlled vocabs assoc id nullable

* #10292 migrated controlled vocabs setting name from symbolics to name
asmecher pushed a commit to pkp/ops that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
2a2f7a3
asmecher pushed a commit to pkp/ops that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
68359f6
asmecher pushed a commit to pkp/ops that referenced this issue Jan 4, 2025
@touhidurabir @asmecher
pkp/pkp-lib#10292 vocab assoc id nullable and setting anme update for…
85fd20a 
…m symbolic to name
@asmecher
Copy link
Member Author

asmecher commented Jan 4, 2025

All merged -- thanks, @touhidurabir!

@asmecher asmecher closed this as completed Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
3 participants
@asmecher @touhidurabir @mreiko