From e2604ff1bac1d2e1d28b30f346fb8c7564453326 Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Sun, 9 Feb 2025 12:36:10 +0600 Subject: [PATCH 1/6] pkp/pkp-lib#4787 added install and upgrade migration --- api/v1/submissions/index.php | 2 + dbscripts/xml/install.xml | 1 + dbscripts/xml/upgrade.xml | 4 ++ locale/en/default.po | 9 ++++ locale/en/manager.po | 9 ++++ schemas/context.json | 14 +++++++ schemas/submission.json | 79 ++++++++++++++++++++++++++++++++++++ 7 files changed, 118 insertions(+) diff --git a/api/v1/submissions/index.php b/api/v1/submissions/index.php index 1fbf71000ff..26cac7a3deb 100644 --- a/api/v1/submissions/index.php +++ b/api/v1/submissions/index.php @@ -23,6 +23,8 @@ if (strpos($requestPath, '/files')) { return new \PKP\handler\APIHandler(new \PKP\API\v1\submissions\PKPSubmissionFileController()); +} elseif (strpos($requestPath, '/suggestions')) { + return new \PKP\handler\APIHandler(new PKP\API\v1\reviewers\suggestions\ReviewerSuggestionController()); } else { return new \PKP\handler\APIHandler(new \APP\API\v1\submissions\SubmissionController()); } diff --git a/dbscripts/xml/install.xml b/dbscripts/xml/install.xml index 4a405c5d50b..dadd4003a8a 100644 --- a/dbscripts/xml/install.xml +++ b/dbscripts/xml/install.xml @@ -35,6 +35,7 @@ + diff --git a/dbscripts/xml/upgrade.xml b/dbscripts/xml/upgrade.xml index 9d50832cb6f..0d273999d2a 100644 --- a/dbscripts/xml/upgrade.xml +++ b/dbscripts/xml/upgrade.xml @@ -157,6 +157,10 @@ + + + + diff --git a/locale/en/default.po b/locale/en/default.po index 0ffa01604ca..b96f03ae32f 100644 --- a/locale/en/default.po +++ b/locale/en/default.po @@ -153,3 +153,12 @@ msgstr "External Reviewers" msgid "default.groups.abbrev.externalReviewer" msgstr "ER" + +msgid "default.submission.step.reviewerSuggestions" +msgstr "" +"

When submitting your article, you have the option to suggest 2/3 potential " +"reviewers. This can help streamline the review process and provide valueable " +"input for the editorial team. Please choose reviewers who are expert in your " +"field and have no conflict of interest with your work. This feature aims to " +"enhance the review process and and support a more efficient experience for both " +"authors and presses.

" diff --git a/locale/en/manager.po b/locale/en/manager.po index d8850a69158..371c2e9de86 100644 --- a/locale/en/manager.po +++ b/locale/en/manager.po @@ -769,6 +769,15 @@ msgstr "Reviewer Ratings" msgid "manager.setup.reviewOptions.reviewerReminders" msgstr "Reviewer Reminders" +msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled" +msgstr "Reviewer Suggestion at Submission" + +msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.description" +msgstr "Author can suggest few potential reviewers before completing the submission which can streamline the review process and provide valuable input for editorial team." + +msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.label" +msgstr "Allow authors to suggest potential reviewers at submission process" + msgid "manager.setup.reviewPolicy" msgstr "Review Policy" diff --git a/schemas/context.json b/schemas/context.json index f96c59c0d1b..52b6e854f4b 100644 --- a/schemas/context.json +++ b/schemas/context.json @@ -177,6 +177,20 @@ "type": "boolean", "default": false, "description": "Whether each publication version should receive a unique DOI" + }, + "reviewerSuggestionEnabled": { + "type": "boolean", + "validation": [ + "nullable" + ] + }, + "reviewerSuggestionsHelp": { + "type": "string", + "multilingual": true, + "validation": [ + "nullable" + ], + "defaultLocaleKey": "default.submission.step.reviewerSuggestions" } } } diff --git a/schemas/submission.json b/schemas/submission.json index 526a21db6cc..1156337ea17 100644 --- a/schemas/submission.json +++ b/schemas/submission.json @@ -48,6 +48,85 @@ "validation": [ "in:1,2" ] + }, + "reviewerSuggestions": { + "type": "array", + "description": "Information about suggested reviewers at the time of submission.", + "readOnly": true, + "items": { + "type": "object", + "properties": { + "id": { + "type": "integer" + }, + "familyName" : { + "type": "string", + "multilingual": true, + "apiSummary": true + }, + "givenName": { + "type": "string", + "multilingual": true, + "apiSummary": true + }, + "fullName": { + "type": "string", + "multilingual": true, + "apiSummary": true + }, + "email": { + "type": "string", + "apiSummary": true + }, + "orcidId": { + "type": "string", + "apiSummary": true, + "validation": [ + "nullable" + ] + }, + "suggestionReason": { + "type": "string", + "multilingual": true, + "apiSummary": true + }, + "affiliation" : { + "type": "string", + "multilingual": true, + "apiSummary": true + }, + "approvedAt": { + "type": "string", + "apiSummary": true, + "description": "The date suggestion was approved as reviewer.", + "validation": [ + "nullable", + "date:Y-m-d H:i:s" + ] + }, + "existingUserId": { + "type": "integer", + "apiSummary": true, + "description": "The existing user id if already present as an user.", + "validation": [ + "nullable" + ] + }, + "existingReviewerRole": { + "type": "boolean", + "apiSummary": true, + "description": "The existing user has reviewer role when already there is an existing user association." + }, + "reviewerId": { + "type": "integer", + "apiSummary": true, + "description": "The existing user id with reviewer role who as been mapped to this suggestion after the suggestion has made", + "validation": [ + "nullable" + ] + } + } + } } } } From 4e611d254dd97608770bfc74f5d94303de5cae1f Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Sun, 9 Feb 2025 15:40:05 +0600 Subject: [PATCH 2/6] pkp/pkp-lib#4787 added missing migration --- .../v3_6_0/I4787_AddReviewSuggestionHelp.php | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php diff --git a/classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php b/classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php new file mode 100644 index 00000000000..e5ddb312c1e --- /dev/null +++ b/classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php @@ -0,0 +1,23 @@ + Date: Sun, 23 Feb 2025 22:40:32 +0600 Subject: [PATCH 3/6] pkp/pkp-lib#4787 moved migrations for 3.5.0 --- .../{v3_6_0 => v3_5_0}/I4787_AddReviewSuggestionHelp.php | 6 +++--- dbscripts/xml/upgrade.xml | 6 ++---- 2 files changed, 5 insertions(+), 7 deletions(-) rename classes/migration/upgrade/{v3_6_0 => v3_5_0}/I4787_AddReviewSuggestionHelp.php (78%) diff --git a/classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php b/classes/migration/upgrade/v3_5_0/I4787_AddReviewSuggestionHelp.php similarity index 78% rename from classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php rename to classes/migration/upgrade/v3_5_0/I4787_AddReviewSuggestionHelp.php index e5ddb312c1e..91a08615031 100644 --- a/classes/migration/upgrade/v3_6_0/I4787_AddReviewSuggestionHelp.php +++ b/classes/migration/upgrade/v3_5_0/I4787_AddReviewSuggestionHelp.php @@ -1,7 +1,7 @@ + + - - - - From 95428b39aca5c594a860df74eb8a2e5218726d61 Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Tue, 25 Feb 2025 18:54:55 +0600 Subject: [PATCH 4/6] pkp/pkp-lib#4787 translation update --- locale/en/default.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locale/en/default.po b/locale/en/default.po index b96f03ae32f..8edd41fc954 100644 --- a/locale/en/default.po +++ b/locale/en/default.po @@ -156,7 +156,7 @@ msgstr "ER" msgid "default.submission.step.reviewerSuggestions" msgstr "" -"

When submitting your article, you have the option to suggest 2/3 potential " +"

When submitting your monograph, you have the option to suggest several potential " "reviewers. This can help streamline the review process and provide valueable " "input for the editorial team. Please choose reviewers who are expert in your " "field and have no conflict of interest with your work. This feature aims to " From af7c39bd6f09650d418998fadb9d8ab8af8374aa Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Wed, 26 Feb 2025 15:23:48 +0600 Subject: [PATCH 5/6] pkp/pkp-lib#4787 centralise translations --- locale/en/default.po | 9 --------- locale/en/manager.po | 9 --------- 2 files changed, 18 deletions(-) diff --git a/locale/en/default.po b/locale/en/default.po index 8edd41fc954..0ffa01604ca 100644 --- a/locale/en/default.po +++ b/locale/en/default.po @@ -153,12 +153,3 @@ msgstr "External Reviewers" msgid "default.groups.abbrev.externalReviewer" msgstr "ER" - -msgid "default.submission.step.reviewerSuggestions" -msgstr "" -"

When submitting your monograph, you have the option to suggest several potential " -"reviewers. This can help streamline the review process and provide valueable " -"input for the editorial team. Please choose reviewers who are expert in your " -"field and have no conflict of interest with your work. This feature aims to " -"enhance the review process and and support a more efficient experience for both " -"authors and presses.

" diff --git a/locale/en/manager.po b/locale/en/manager.po index 371c2e9de86..d8850a69158 100644 --- a/locale/en/manager.po +++ b/locale/en/manager.po @@ -769,15 +769,6 @@ msgstr "Reviewer Ratings" msgid "manager.setup.reviewOptions.reviewerReminders" msgstr "Reviewer Reminders" -msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled" -msgstr "Reviewer Suggestion at Submission" - -msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.description" -msgstr "Author can suggest few potential reviewers before completing the submission which can streamline the review process and provide valuable input for editorial team." - -msgid "manager.setup.reviewOptions.reviewerSuggestionEnabled.label" -msgstr "Allow authors to suggest potential reviewers at submission process" - msgid "manager.setup.reviewPolicy" msgstr "Review Policy" From b9d04da4d47f74655b2980e32880653488e2777f Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Sun, 9 Feb 2025 12:36:58 +0600 Subject: [PATCH 6/6] pkp/pkp-lib#4787 Submodule Update ##touhidurabir/i4787_main## pkp/pkp-lib#4787 Submodule Update ##touhidurabir/i4787_main## --- lib/pkp | 2 +- lib/ui-library | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pkp b/lib/pkp index 0962845f60e..6bad555b214 160000 --- a/lib/pkp +++ b/lib/pkp @@ -1 +1 @@ -Subproject commit 0962845f60e2f88eb08af0670cfc690c5cee7b7b +Subproject commit 6bad555b2146b159d5a055a396484be3c058b82e diff --git a/lib/ui-library b/lib/ui-library index a463c45c1d3..18f36a34163 160000 --- a/lib/ui-library +++ b/lib/ui-library @@ -1 +1 @@ -Subproject commit a463c45c1d361f18021058135ee8387f950482f8 +Subproject commit 18f36a34163e3fa25a275d09c69d021ea94bb282