From c0b543e9ecec2ff5820516cab00c8c07875da2eb Mon Sep 17 00:00:00 2001 From: Bozana Bokan Date: Wed, 4 Dec 2024 15:48:19 +0100 Subject: [PATCH] adapt language distribution --- .../Z_MonographViewDCMetadata.cy.js | 12 +++---- .../dublinCoreMeta/DublinCoreMetaPlugin.php | 33 +++++++++---------- .../googleScholar/GoogleScholarPlugin.php | 8 ++--- 3 files changed, 26 insertions(+), 27 deletions(-) diff --git a/cypress/tests/integration/Z_MonographViewDCMetadata.cy.js b/cypress/tests/integration/Z_MonographViewDCMetadata.cy.js index 61ab49227a0..b2a09d27099 100644 --- a/cypress/tests/integration/Z_MonographViewDCMetadata.cy.js +++ b/cypress/tests/integration/Z_MonographViewDCMetadata.cy.js @@ -191,7 +191,7 @@ describe('Monograph View Metadata - DC Plugin', function() { ] }, { - locale: 'fr', + locale: 'fr-CA', contents: [ submission.localeMetadata .find(element => element.locale == 'fr_CA') @@ -212,7 +212,7 @@ describe('Monograph View Metadata - DC Plugin', function() { ] }, { - locale: 'fr', + locale: 'fr-CA', contents: [ submission.localeTitles.fr_CA.abstract ] @@ -223,7 +223,7 @@ describe('Monograph View Metadata - DC Plugin', function() { element: 'DC.Title.Alternative', values: [ { - locale: 'fr', + locale: 'fr-CA', contents: [ submission.localeTitles.fr_CA.prefix + ' ' + submission.localeTitles.fr_CA.title + ': ' + submission.localeTitles.fr_CA.subtitle ] @@ -246,7 +246,7 @@ describe('Monograph View Metadata - DC Plugin', function() { }, { - locale: 'fr', + locale: 'fr-CA', contents: [ submission.localeMetadata .find(element => element.locale == 'fr_CA') @@ -276,7 +276,7 @@ describe('Monograph View Metadata - DC Plugin', function() { ) }, { - locale: 'fr', + locale: 'fr-CA', contents: submission.localeMetadata .find(element => element.locale == 'fr_CA') .manyValues @@ -345,7 +345,7 @@ describe('Monograph View Metadata - DC Plugin', function() { withScheme: [ { element: 'DC.Language', - scheme: 'ISO639-1', + scheme: 'rfc5646', content: 'en' }, { diff --git a/plugins/generic/dublinCoreMeta/DublinCoreMetaPlugin.php b/plugins/generic/dublinCoreMeta/DublinCoreMetaPlugin.php index 2e44e602d95..0dd68da310d 100644 --- a/plugins/generic/dublinCoreMeta/DublinCoreMetaPlugin.php +++ b/plugins/generic/dublinCoreMeta/DublinCoreMetaPlugin.php @@ -16,7 +16,6 @@ use APP\core\Application; use APP\template\TemplateManager; -use PKP\i18n\LocaleConversion; use PKP\plugins\GenericPlugin; use PKP\plugins\Hook; @@ -84,7 +83,7 @@ public function monographView($hookName, $args) if ($supportingAgencies = $publication->getData('supportingAgencies')) { foreach ($supportingAgencies as $locale => $localeSupportingAgencies) { foreach ($localeSupportingAgencies as $i => $supportingAgency) { - $templateMgr->addHeader('dublinCoreSponsor' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreSponsor' . $locale . $i++, ''); } } } @@ -92,7 +91,7 @@ public function monographView($hookName, $args) if ($coverages = $publication->getData('coverage')) { foreach ($coverages as $locale => $coverage) { if ($coverage != '') { - $templateMgr->addHeader('dublinCoreCoverage' . $locale, ''); + $templateMgr->addHeader('dublinCoreCoverage' . $locale, ''); } } } @@ -118,7 +117,7 @@ public function monographView($hookName, $args) $abstracts = $isChapterRequest ? $chapter->getData('abstract') : $publication->getData('abstract'); foreach ($abstracts ?: [] as $locale => $abstract) { if ($abstract != '') { - $templateMgr->addHeader('dublinCoreAbstract' . $locale, ''); + $templateMgr->addHeader('dublinCoreAbstract' . $locale, ''); } } @@ -136,7 +135,7 @@ public function monographView($hookName, $args) $templateMgr->addHeader('dublinCoreUri', ''); - $templateMgr->addHeader('dublinCoreLanguage', ''); + $templateMgr->addHeader('dublinCoreLanguage', ''); if (($copyrightHolder = $publication->getData('copyrightHolder', $publicationLocale)) && ($copyrightYear = $publication->getData('copyrightYear'))) { $templateMgr->addHeader('dublinCoreCopyright', ''); @@ -151,14 +150,14 @@ public function monographView($hookName, $args) if ($subjects = $publication->getData('subjects')) { foreach ($subjects as $locale => $localeSubjects) { foreach ($localeSubjects as $i => $subject) { - $templateMgr->addHeader('dublinCoreSubject' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreSubject' . $locale . $i++, ''); } } } if ($keywords = $publication->getData('keywords')) { foreach ($keywords as $locale => $localeKeywords) { foreach ($localeKeywords as $i => $keyword) { - $templateMgr->addHeader('dublinCoreKeyword' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreKeyword' . $locale . $i++, ''); } } } @@ -168,7 +167,7 @@ public function monographView($hookName, $args) $titles = $isChapterRequest ? $chapter->getFullTitles() : $publication->getFullTitles(); foreach ($titles as $locale => $altTitle) { if ($title != '' && $locale != $publicationLocale) { - $templateMgr->addHeader('dublinCoreAltTitle' . $locale, ''); + $templateMgr->addHeader('dublinCoreAltTitle' . $locale, ''); } } @@ -176,7 +175,7 @@ public function monographView($hookName, $args) if ($types = $publication->getData('type')) { foreach ($types as $locale => $type) { if ($type != '') { - $templateMgr->addHeader('dublinCoreType' . $locale, ''); + $templateMgr->addHeader('dublinCoreType' . $locale, ''); } } } @@ -221,7 +220,7 @@ public function monographFileView($hookName, $args) if ($supportingAgencies = $publication->getData('supportingAgencies')) { foreach ($supportingAgencies as $locale => $localeSupportingAgencies) { foreach ($localeSupportingAgencies as $i => $supportingAgency) { - $templateMgr->addHeader('dublinCoreSponsor' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreSponsor' . $locale . $i++, ''); } } } @@ -229,7 +228,7 @@ public function monographFileView($hookName, $args) if ($coverages = $publication->getData('coverage')) { foreach ($coverages as $locale => $coverage) { if ($coverage != '') { - $templateMgr->addHeader('dublinCoreCoverage' . $locale, ''); + $templateMgr->addHeader('dublinCoreCoverage' . $locale, ''); } } } @@ -255,7 +254,7 @@ public function monographFileView($hookName, $args) $abstracts = $chapter ? $chapter->getData('abstract') : $publication->getData('abstract'); foreach ($abstracts ?: [] as $locale => $abstract) { if ($abstract != '') { - $templateMgr->addHeader('dublinCoreAbstract' . $locale, ''); + $templateMgr->addHeader('dublinCoreAbstract' . $locale, ''); } } @@ -279,7 +278,7 @@ public function monographFileView($hookName, $args) $templateMgr->addHeader('dublinCoreUri', ''); - $templateMgr->addHeader('dublinCoreLanguage', ''); + $templateMgr->addHeader('dublinCoreLanguage', ''); if (($copyrightHolder = $publication->getData('copyrightHolder', $publicationLocale)) && ($copyrightYear = $publication->getData('copyrightYear'))) { $templateMgr->addHeader('dublinCoreCopyright', ''); @@ -298,14 +297,14 @@ public function monographFileView($hookName, $args) if ($subjects = $publication->getData('subjects')) { foreach ($subjects as $locale => $localeSubjects) { foreach ($localeSubjects as $i => $subject) { - $templateMgr->addHeader('dublinCoreSubject' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreSubject' . $locale . $i++, ''); } } } if ($keywords = $publication->getData('keywords')) { foreach ($keywords as $locale => $localeKeywords) { foreach ($localeKeywords as $i => $keyword) { - $templateMgr->addHeader('dublinCoreKeyword' . $locale . $i++, ''); + $templateMgr->addHeader('dublinCoreKeyword' . $locale . $i++, ''); } } } @@ -316,7 +315,7 @@ public function monographFileView($hookName, $args) $titles = $chapter ? $chapter->getFullTitles() : $publication->getFullTitles(); foreach ($titles as $locale => $altTitle) { if ($title != '' && $locale != $publicationLocale) { - $templateMgr->addHeader('dublinCoreAltTitle' . $locale, ''); + $templateMgr->addHeader('dublinCoreAltTitle' . $locale, ''); } } @@ -324,7 +323,7 @@ public function monographFileView($hookName, $args) if ($types = $publication->getData('type')) { foreach ($types as $locale => $type) { if ($type != '') { - $templateMgr->addHeader('dublinCoreType' . $locale, ''); + $templateMgr->addHeader('dublinCoreType' . $locale, ''); } } } diff --git a/plugins/generic/googleScholar/GoogleScholarPlugin.php b/plugins/generic/googleScholar/GoogleScholarPlugin.php index a45b5d6e2e2..9c1a746cf3f 100644 --- a/plugins/generic/googleScholar/GoogleScholarPlugin.php +++ b/plugins/generic/googleScholar/GoogleScholarPlugin.php @@ -91,7 +91,7 @@ public function monographView($hookName, $args) $templateMgr->addHeader('googleScholarTitle', ''); // Language - $templateMgr->addHeader('googleScholarLanguage', ''); + $templateMgr->addHeader('googleScholarLanguage', ''); // Publication date $datePublished = $isChapterRequest @@ -115,7 +115,7 @@ public function monographView($hookName, $args) // Abstract $abstract = $isChapterRequest ? $chapter->getLocalizedData('abstract', $publicationLocale) : $publication->getLocalizedData('abstract', $publicationLocale); if ($abstract != '') { - $templateMgr->addHeader('googleScholarAbstract', ''); + $templateMgr->addHeader('googleScholarAbstract', ''); } // Publication DOI @@ -127,7 +127,7 @@ public function monographView($hookName, $args) if ($subjects = $publication->getData('subjects')) { foreach ($subjects as $locale => $localeSubjects) { foreach ($localeSubjects as $i => $subject) { - $templateMgr->addHeader('googleScholarSubject' . $i++, ''); + $templateMgr->addHeader('googleScholarSubject' . $i++, ''); } } } @@ -136,7 +136,7 @@ public function monographView($hookName, $args) if ($keywords = $publication->getData('keywords')) { foreach ($keywords as $locale => $localeKeywords) { foreach ($localeKeywords as $i => $keyword) { - $templateMgr->addHeader('googleScholarKeyword' . $i++, ''); + $templateMgr->addHeader('googleScholarKeyword' . $i++, ''); } } }