Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SwiftLint #21

Open
pjechris opened this issue Aug 19, 2022 · 0 comments
Open

Add SwiftLint #21

pjechris opened this issue Aug 19, 2022 · 0 comments
Labels
good first issue tooling

Comments

@pjechris
Copy link
Owner

pjechris commented Aug 19, 2022 •
edited
Loading

Add SwiftLint to lint code:

  1. Add a step to run linter in github test workflow
  2. Add swift format file with following rules (if they exist)
    • space/indentation: 4
    • max line width: 120
    • cases should not be indented
    • else and catch should go on a new line
    • return should go on a new line
    • warnings should be disallowed (aka max warning is 0)

(The rules should be adapted to make it work with current code)
@pjechris pjechris changed the title Add swift format Add SwiftLint Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjechris