Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with comments in cells and with indented commands #1

Open
peter-lyons-kehl opened this issue Sep 11, 2016 · 0 comments
Open

Comments

@peter-lyons-kehl
Copy link

Hi Paul,

Thank you for your Selenese project.

I've created SeLite (http://selite.github.io). It extends Selenium IDE to make it more productive. One recent feature of SeLite is that it makes Selenium IDE save Selenese comments not as HTML comments anymore. Rather, it saves them as <td colspan="3" class="comment">...</td>. That enables

  • users to see the comments in a browser, and
  • HTML diff tools (https://github.com/DaisyDiff/DaisyDiff) to show changes in Selenese comments (which most tools ignore if the changes are in HTML comments).

That migration from HTML comments to special table cells would break your parsing: https://github.com/pjcj/Selenese/blob/master/bin/selenese#L138. However, I'm not sure of what https://github.com/pjcj/Selenese/blob/master/bin/selenese#L178 does.

May I ask that you make Selenese module ignore that have class="comment", please.

Also, SeLite allows indentation of the commands. It adds XML non-breakable space(s) &#160; in front of indented commands. May I ask you to skip those non-breakable spaces, please.

(For details of my code see https://github.com/SeLite/SeLite/blob/master/clipboard-and-indent/src/chrome/content/extensions/html.js#L459 and https://github.com/SeLite/SeLite/blob/62d34cf395f89afc4420e5726ebe65dd6cc4f0aa/clipboard-and-indent/src/chrome/content/extensions/html.js#L88.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant