You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue: We should not be always setting the flag to false. Because if the user doubles clicks in the same time period, we don't change the days (as useEffect doesn't run again) but we set the flag to false due to which the circular progress comes up and it persists as the flag is never reset to true again.
Change Needed: Condition to set the flag to false
onClick={() => {
setDays(day.value); if (days !== day.value) setflag(false);
}}
Thanks!
The text was updated successfully, but these errors were encountered:
priyeshbitsp
changed the title
Issue in the merged PR #1
Issue in the latest merged PR
May 29, 2022
Hello @Siddharth352 @piyush-eon
There is a minor miss in this #1
Issue: We should not be always setting the flag to false. Because if the user doubles clicks in the same time period, we don't change the days (as useEffect doesn't run again) but we set the flag to false due to which the circular progress comes up and it persists as the flag is never reset to true again.
Change Needed: Condition to set the flag to false
onClick={() => {
setDays(day.value);
if (days !== day.value) setflag(false);
}}
Thanks!
The text was updated successfully, but these errors were encountered: