Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in the latest merged PR #5

Open
priyeshbitsp opened this issue May 29, 2022 · 0 comments
Open

Issue in the latest merged PR #5

priyeshbitsp opened this issue May 29, 2022 · 0 comments

Comments

@priyeshbitsp
Copy link

Hello @Siddharth352 @piyush-eon

There is a minor miss in this #1

Issue: We should not be always setting the flag to false. Because if the user doubles clicks in the same time period, we don't change the days (as useEffect doesn't run again) but we set the flag to false due to which the circular progress comes up and it persists as the flag is never reset to true again.

Change Needed: Condition to set the flag to false

onClick={() => {
setDays(day.value);
if (days !== day.value) setflag(false);
}}

Thanks!

@priyeshbitsp priyeshbitsp changed the title Issue in the merged PR #1 Issue in the latest merged PR May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant