You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So what's the process and/or 'social contract' for merging PRs?
I've had a PR in the repo for over a week. There has been no comment and no action on it.
Should I have done something besides just making the PR? Should I have 'assigned' someone? Different repos have different rules, and I just want to make sure I know what the rules are here. Maybe they should be in the readme?
The text was updated successfully, but these errors were encountered:
In one repo I work in, the rule is that for a PR to be merged, it must have two external reviews, and be open for 24h. This ensures that at least two people who aren't the author review the change, and that it is 'available' for a period that gives folks a chance to 'notice' it before getting merged. That's probably a bit much for this repo, but its an example.
Maybe the rule is: you can't merge your own PR. This means that just one other person needs to look at it, and then merge it.
Clearly, there are lots of schemes to employ, all equally valid.
So what's the process and/or 'social contract' for merging PRs?
I've had a PR in the repo for over a week. There has been no comment and no action on it.
Should I have done something besides just making the PR? Should I have 'assigned' someone? Different repos have different rules, and I just want to make sure I know what the rules are here. Maybe they should be in the readme?
The text was updated successfully, but these errors were encountered: