Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the policy for PRs in this repo? #11

Open
rbeyer opened this issue Sep 27, 2019 · 1 comment
Open

What's the policy for PRs in this repo? #11

rbeyer opened this issue Sep 27, 2019 · 1 comment

Comments

@rbeyer
Copy link
Member

rbeyer commented Sep 27, 2019

So what's the process and/or 'social contract' for merging PRs?

I've had a PR in the repo for over a week. There has been no comment and no action on it.

Should I have done something besides just making the PR? Should I have 'assigned' someone? Different repos have different rules, and I just want to make sure I know what the rules are here. Maybe they should be in the readme?

@rbeyer
Copy link
Member Author

rbeyer commented Sep 28, 2019

In one repo I work in, the rule is that for a PR to be merged, it must have two external reviews, and be open for 24h. This ensures that at least two people who aren't the author review the change, and that it is 'available' for a period that gives folks a chance to 'notice' it before getting merged. That's probably a bit much for this repo, but its an example.

Maybe the rule is: you can't merge your own PR. This means that just one other person needs to look at it, and then merge it.

Clearly, there are lots of schemes to employ, all equally valid.

@rbeyer rbeyer mentioned this issue Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant