Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart-rename pass not renames property inside MemberExpression #135

Closed
avrnex opened this issue Aug 9, 2024 · 1 comment · May be fixed by #133
Closed

smart-rename pass not renames property inside MemberExpression #135

avrnex opened this issue Aug 9, 2024 · 1 comment · May be fixed by #133
Labels
bug Something isn't working scope: unminify

Comments

@avrnex
Copy link

avrnex commented Aug 9, 2024

Describe the bug

smart-rename pass not renames property inside MemberExpression

Input code

function test({foo: f, bar: b}) {
  console.log(f, b, f[b]);
}

Steps to reproduce

Run wakaru with input code and smart-rename pass is switched to on.

Expected behavior

in f[b] f is renamed to foo and b is renamed to bar.

function test({foo, bar}) {
  console.log(foo, bar, foo[bar]);
}

Actual behavior

in f[b] f is renamed to foo, but b is NOT renamed to bar.

function test({foo, bar}) {
  console.log(foo, bar, foo[b]);
}
@pionxzh
Copy link
Owner

pionxzh commented Aug 10, 2024

Nice catch. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope: unminify
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants