From d517f00e87ceedde3889174775202030c49c0ccf Mon Sep 17 00:00:00 2001
From: Juliusz Chroboczek <jch@irif.fr>
Date: Thu, 2 Jan 2025 18:40:17 +0100
Subject: [PATCH] Minor fixes to TestInterceptorNack

One variable was misnamed, and we never checked for the end
of the RTCP loop.
---
 interceptor_test.go | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/interceptor_test.go b/interceptor_test.go
index 59738757182..924bada7f69 100644
--- a/interceptor_test.go
+++ b/interceptor_test.go
@@ -289,7 +289,7 @@ func Test_Interceptor_ZeroSSRC(t *testing.T) {
 }
 
 // TestInterceptorNack is an end-to-end test for the NACK sender.
-// It test that:
+// It tests that:
 //   - we get a NACK if we negotiated generic NACks;
 //   - we don't get a NACK if we did not negotiate generick NACKs;
 //   - the NACK corresponds to the missing packet.
@@ -306,16 +306,16 @@ func testInterceptorNack(t *testing.T, requestNack bool) {
 
 	ir := interceptor.Registry{}
 	m := MediaEngine{}
-	var capability []RTCPFeedback
+	var feedback []RTCPFeedback
 	if requestNack {
-		capability = append(capability, RTCPFeedback{"nack", ""})
+		feedback = append(feedback, RTCPFeedback{"nack", ""})
 	}
 	err := m.RegisterCodec(
 		RTPCodecParameters{
 			RTPCodecCapability: RTPCodecCapability{
 				"video/VP8", 90000, 0,
 				"",
-				capability,
+				feedback,
 			},
 			PayloadType: 96,
 		},
@@ -424,7 +424,6 @@ func testInterceptorNack(t *testing.T, requestNack bool) {
 	assert.NoError(t, err)
 	err = pc2.Close()
 	assert.NoError(t, err)
-	<-rtcpDone
 
 	if requestNack {
 		if !gotNack {