Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependency warning #26

Open
fiznool opened this issue Mar 20, 2020 · 3 comments
Open

Unmet peer dependency warning #26

fiznool opened this issue Mar 20, 2020 · 3 comments

Comments

@fiznool
Copy link

fiznool commented Mar 20, 2020

Upon installing this module with yarn the following warning is encountered:

warning " > [email protected]" has unmet peer dependency "debug@>=2".

I understand that pino-debug requires debug directly in the code, but given that this module is mostly useful for piping 'debug' logs from third party libraries, I would not expect to have to also install debug, as it comes bundled with the third party lib.

I don't really know what the solution is, just that the warning is a little annoying - everything still seems to work ok without explicitly installing debug.

@mcollina
Copy link
Member

I have a feeling that the implementation of peerDependency of yarn and how this module work is incompatible with yarn.

@mcollina
Copy link
Member

cc @davidmarkclements

@micalevisk
Copy link

micalevisk commented Apr 16, 2022

looks like you guys can do something other than making the peer dep optional (which I think isn't good) as this issue is related on how Yarn triggers peer deps warnings. See yarnpkg/yarn#4675

Demo with Yarn 1.22.5:

yarn-demo.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants