Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screencopies without overlay cursor cause the pointer to disappear #190

Open
Ottatop opened this issue Apr 4, 2024 · 1 comment
Open
Labels
bug Something isn't working low priority Low priority items winit Concerns the winit backend

Comments

@Ottatop
Copy link
Collaborator

Ottatop commented Apr 4, 2024

In udev this is because Smithay/smithay#1378 causes any screencopying to have a hole under the cursor if it's on the cursor plane. As a workaround, screencopies cause the pointer to be rendered on the primary plane instead. A consequence of this is that copying the frame will always include the pointer, and I can't remove the pointer from the composite after the fact. To get no-cursor screencopies to work, I remove the pointer from being drawn altogether.

In winit this is because the pointer is always composited together with the rest of the things, and I'm not rendering it for the same reason. Drawing the pointer after a screencopy might work but I haven't tried that out. It also might run into the same issue as above and create a hole around the cursor.

This should not be meaningful if you're doing a single screenshot without the cursor, but if you're doing a screen recording without the cursor (for example wl-mirror --no-show-cursor <output>) then the cursor will dim, flicker, and/or straight up disappear.

@Ottatop Ottatop added bug Something isn't working low priority Low priority items labels Apr 4, 2024
@Ottatop
Copy link
Collaborator Author

Ottatop commented Jun 21, 2024

As of #258 this has been fixed on the udev backend.

@Ottatop Ottatop added the winit Concerns the winit backend label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Low priority items winit Concerns the winit backend
Projects
None yet
Development

No branches or pull requests

1 participant