-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: move all extra columns to the end in ExpandVirtualColumn (#58499) #58585
base: release-8.5
Are you sure you want to change the base?
planner/core: move all extra columns to the end in ExpandVirtualColumn (#58499) #58585
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58585 +/- ##
================================================
Coverage ? 56.8601%
================================================
Files ? 1770
Lines ? 627053
Branches ? 0
================================================
Hits ? 356543
Misses ? 246399
Partials ? 24111
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #58499
What problem does this PR solve?
Issue Number: close #58475, close #56013
Problem Summary:
What changed and how does it work?
As title. Previously we only move column with id
ExtraHandleID
to the end, but we forgot some other extra columns.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.