Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check max row size when parsing csv #58590

Open
D3Hunter opened this issue Dec 27, 2024 · 1 comment · May be fixed by #58592
Open

check max row size when parsing csv #58590

D3Hunter opened this issue Dec 27, 2024 · 1 comment · May be fixed by #58592
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Dec 27, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

in #40400, we have check whether a single field exceed the max entry size, but we also need to check this for the whole row, to avoid when the data file is corrupted or the input param doesn't match with the file, and causes the parser mistakenly read a vary long row and cause oom

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master
@D3Hunter D3Hunter added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug. labels Dec 27, 2024
@D3Hunter D3Hunter linked a pull request Dec 27, 2024 that will close this issue
Open
13 tasks
@D3Hunter
Copy link
Contributor Author

for SQL/Parquet files, as they have syntax, it's quite rare to have a row longer than 128M, so we don't handle them right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importinto/lightning: check max row size when parsing csv to avoid OOM D3Hunter/tidb
1 participant
@D3Hunter