Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: avoid schema version without diff #58549

Closed
wants to merge 1 commit into from
Closed

ddl: avoid schema version without diff #58549

wants to merge 1 commit into from

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Dec 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58486, #58483

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

same step as in #58486, now tidb-server-5000 will fail the txn with write conflict, and tidb-server-4000 will run it successfully, and all node can see the new table

[2024/12/26 15:16:55.611 +08:00] [INFO] [job_scheduler.go:597] ["handle ddl job failed"] [category=ddl] [jobID=111] [conn=2797600772] [error="[kv:9007]Write conflict
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 26, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 26, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-26 07:48:32.816572534 +0000 UTC m=+1720702.905375076: ☑️ agreed by wjhuang2016.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8509%. Comparing base (8e1a47d) to head (a71da8b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58549        +/-   ##
================================================
+ Coverage   73.5154%   74.8509%   +1.3354%     
================================================
  Files          1681       1726        +45     
  Lines        464479     472563      +8084     
================================================
+ Hits         341464     353718     +12254     
+ Misses       102179      96564      -5615     
- Partials      20836      22281      +1445
Flag Coverage Δ
integration 48.7106% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.2000% <ø> (+15.4135%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

@D3Hunter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test a71da8b link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 a71da8b link true /test check-dev2
idc-jenkins-ci-tidb/unit-test a71da8b link true /test unit-test
pull-br-integration-test a71da8b link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@D3Hunter
Copy link
Contributor Author

as DDL runs concurrently, almost all running DDL txn overlap in time range, so more write conflict and makes DDL performance worse

@D3Hunter D3Hunter closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@D3Hunter @wjhuang2016