Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: set min for hashagg | tidb-test=pr/2407 #56452

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

planner: set min for hashagg | tidb-test=pr/2407 #56452

wants to merge 18 commits into from
+205 −207

Conversation

terry1purcell
Copy link
Contributor

@terry1purcell terry1purcell commented Oct 5, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #56455

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner labels Oct 5, 2024
@tiprow tiprow
Copy link

tiprow bot commented Oct 5, 2024

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.4989%. Comparing base (74034d4) to head (1a77f97).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56452        +/-   ##
================================================
+ Coverage   73.3650%   75.4989%   +2.1339%     
================================================
  Files          1624       1646        +22     
  Lines        448069     456870      +8801     
================================================
+ Hits         328726     344932     +16206     
+ Misses        99206      90281      -8925     
- Partials      20137      21657      +1520
Flag Coverage Δ
integration 32.4601% <90.9090%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0037% <ø> (+17.4906%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Oct 6, 2024
@terry1purcell terry1purcell changed the title planner: set min for hashagg planner: set min for hashagg | tidb-test/pr=2407 Oct 6, 2024
@terry1purcell terry1purcell changed the title planner: set min for hashagg | tidb-test/pr=2407 planner: set min for hashagg | tidb-test=pr/2407 Oct 6, 2024
@terry1purcell
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Oct 6, 2024

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid, gmhdbjd for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

@terry1purcell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 1a77f97 link true /test unit-test
pull-lightning-integration-test 1a77f97 link true /test pull-lightning-integration-test
idc-jenkins-ci-tidb/check_dev 1a77f97 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 1a77f97 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid Awaiting requested review from AilinKid

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HashAgg and StreamAgg costs are too close for small results
1 participant
@terry1purcell