Skip to content

Commit 3f2efb3

Browse files
committed
adapt
Signed-off-by: Calvin Neo <[email protected]>
1 parent a89e7c1 commit 3f2efb3

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

proxy_components/mock-engine-store/src/mock_cluster/v1/cluster.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ use std::{
1010

1111
use collections::{HashMap, HashSet};
1212
use encryption::DataKeyManager;
13-
use engine_traits::Iterator;
1413
// mock cluster
1514
use engine_traits::{Engines, KvEngine, CF_DEFAULT};
1615
use file_system::IoRateLimiter;
@@ -79,7 +78,7 @@ impl Drop for CallbackLeakDetector {
7978

8079
debug!("before capture");
8180
let bt = std::backtrace::Backtrace::capture();
82-
warn!("callback is dropped"; "backtrace" => ?bt);
81+
debug!("callback is dropped"; "backtrace" => ?bt);
8382
}
8483
}
8584

proxy_components/proxy_server/src/run.rs

+10-3
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ use kvproto::{
4949
raft_serverpb::RaftMessage,
5050
};
5151
use pd_client::{PdClient, RpcClient};
52+
use raft::eraftpb::MessageType;
5253
use raft_log_engine::RaftLogEngine;
5354
use raftstore::{
5455
coprocessor::{config::SplitCheckConfigManager, CoprocessorHost, RegionInfoAccessor},
@@ -139,15 +140,20 @@ impl TiFlashGrpcMessageFilter {
139140
}
140141

141142
impl RaftGrpcMessageFilter for TiFlashGrpcMessageFilter {
142-
fn should_reject_raft_message(&self, _: &RaftMessage) -> bool {
143+
fn should_reject_raft_message(&self, m: &RaftMessage) -> bool {
143144
fail::fail_point!("tiflash_force_reject_raft_append_message", |_| true);
144145

145146
if self.reject_messages_on_memory_ratio < f64::EPSILON {
146147
return false;
147148
}
148149

150+
if m.get_message().get_msg_type() != MessageType::MsgAppend {
151+
return false;
152+
}
153+
149154
let mut usage = 0;
150-
memory_usage_reaches_high_water(&mut usage)
155+
let b = memory_usage_reaches_high_water(&mut usage);
156+
b
151157
}
152158

153159
fn should_reject_snapshot(&self) -> bool {
@@ -158,7 +164,8 @@ impl RaftGrpcMessageFilter for TiFlashGrpcMessageFilter {
158164
}
159165

160166
let mut usage = 0;
161-
memory_usage_reaches_high_water(&mut usage)
167+
let b = memory_usage_reaches_high_water(&mut usage);
168+
b
162169
}
163170
}
164171

proxy_scripts/ci_check.sh

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ elif [[ $M == "testnew" ]]; then
4444
export ENGINE_LABEL_VALUE=tiflash
4545
export RUST_BACKTRACE=full
4646
export ENABLE_FEATURES="test-engine-kv-rocksdb test-engine-raft-raft-engine openssl-vendored"
47+
export LOG_LEVEL=INFO
4748
cargo check --package proxy_server --features="$ENABLE_FEATURES"
4849
# tests based on mock-engine-store, with compat for new proxy
4950
LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib cargo test --package proxy_tests --features="$ENABLE_FEATURES" --test proxy shared::jemalloc --features="jemalloc"

0 commit comments

Comments
 (0)