Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: replace Kafka client with confluent-kafka-go #844

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Jan 9, 2025

What problem does this PR solve?

Issue Number: close #832

What is changed and how it works?

confluent-kafka-go is a lightweight wrapper around librdkafka, a finely tuned C client.

Notice

  1. confluent-kafka-go only supports async producer, we implement sync producer by channel.
  2. confluent-kafka-go does not support mock producers.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@3AceShowHand
Copy link
Collaborator

please split this into multiple small PRs:

  1. remove kafka-go implementation
  2. add confluentic-kafka-go implementation
  3. remove sarama implementaion

@wk989898
Copy link
Collaborator Author

please split this into multiple small PRs:

  1. remove kafka-go implementation
  2. add confluentic-kafka-go implementation
  3. remove sarama implementaion

Most of files are deleted and there is no need to split.

@wk989898 wk989898 marked this pull request as ready for review January 13, 2025 06:28
@wk989898 wk989898 requested a review from 3AceShowHand January 13, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka client is not robust
2 participants