From 2dbad785b37e1765029fc081874ed1039610cb67 Mon Sep 17 00:00:00 2001 From: dbsid Date: Fri, 13 Sep 2024 12:15:15 +0800 Subject: [PATCH 1/4] add logical-import-prep-stmt --- tidb-lightning/tidb-lightning-configuration.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tidb-lightning/tidb-lightning-configuration.md b/tidb-lightning/tidb-lightning-configuration.md index 6f39b803cd2c0..00a5ee9da9459 100644 --- a/tidb-lightning/tidb-lightning-configuration.md +++ b/tidb-lightning/tidb-lightning-configuration.md @@ -258,6 +258,9 @@ strategy = "" # You can decrease this value to reduce the stress on the cluster due to large transactions. # logical-import-batch-rows = 65536 +# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve the performance +# logical-import-prep-stmt = false + [mydumper] # Block size for file reading. Keep it longer than the longest string of the data source. read-block-size = "64KiB" # default value From f020c802d743ba4c4e0556d0e1987fb22201794c Mon Sep 17 00:00:00 2001 From: dbsid Date: Fri, 13 Sep 2024 12:52:37 +0800 Subject: [PATCH 2/4] Update tidb-lightning/tidb-lightning-configuration.md Co-authored-by: Yuanjia Zhang --- tidb-lightning/tidb-lightning-configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tidb-lightning/tidb-lightning-configuration.md b/tidb-lightning/tidb-lightning-configuration.md index 00a5ee9da9459..1ee586de034df 100644 --- a/tidb-lightning/tidb-lightning-configuration.md +++ b/tidb-lightning/tidb-lightning-configuration.md @@ -258,7 +258,7 @@ strategy = "" # You can decrease this value to reduce the stress on the cluster due to large transactions. # logical-import-batch-rows = 65536 -# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve the performance +# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve the performance. # logical-import-prep-stmt = false [mydumper] From bd57d455a68d59fb1a4b9531d4effca747417d2b Mon Sep 17 00:00:00 2001 From: lilin90 Date: Sat, 14 Sep 2024 10:58:35 +0800 Subject: [PATCH 3/4] Update wording --- tidb-lightning/tidb-lightning-configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tidb-lightning/tidb-lightning-configuration.md b/tidb-lightning/tidb-lightning-configuration.md index 1ee586de034df..6051319a2fea7 100644 --- a/tidb-lightning/tidb-lightning-configuration.md +++ b/tidb-lightning/tidb-lightning-configuration.md @@ -258,7 +258,7 @@ strategy = "" # You can decrease this value to reduce the stress on the cluster due to large transactions. # logical-import-batch-rows = 65536 -# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve the performance. +# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve performance. # logical-import-prep-stmt = false [mydumper] From 84322bcf97ea8c3b6603eac6fbe6f9914282b6c4 Mon Sep 17 00:00:00 2001 From: Lilian Lee Date: Wed, 18 Sep 2024 16:20:26 +0800 Subject: [PATCH 4/4] Apply suggestions from code review --- tidb-lightning/tidb-lightning-configuration.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tidb-lightning/tidb-lightning-configuration.md b/tidb-lightning/tidb-lightning-configuration.md index 6051319a2fea7..7652826da08e2 100644 --- a/tidb-lightning/tidb-lightning-configuration.md +++ b/tidb-lightning/tidb-lightning-configuration.md @@ -258,8 +258,8 @@ strategy = "" # You can decrease this value to reduce the stress on the cluster due to large transactions. # logical-import-batch-rows = 65536 -# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve performance. -# logical-import-prep-stmt = false +# In Logical Import Mode, this parameter controls whether to use prepared statements and statement cache to improve performance. The default value is `false`. +logical-import-prep-stmt = false [mydumper] # Block size for file reading. Keep it longer than the longest string of the data source.