Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: cleanup sqlgram #16967

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Apr 7, 2024

What is changed, added or deleted? (Required)

Revert #16049.

After removing media/sqlgram from the master branch, docs in other branches that use the image from media/sqlgram fails to render. For example https://docs.pingcap.com/tidb/stable/sql-statement-use:

image

https://docs-archive.pingcap.com/tidb/v2.1/sql-statement-begin:
image

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added the translation/no-need No need to translate this PR. label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 7, 2024

/cc @dveeden @qiancai

@ti-chi-bot ti-chi-bot bot requested review from dveeden and qiancai April 7, 2024 07:30
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 7, 2024
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a temporary solution?

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 7, 2024
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-07 07:53:07.732654817 +0000 UTC m=+776049.260195361: ☑️ agreed by qiancai.
  • 2024-04-07 08:19:12.104106704 +0000 UTC m=+777613.631647250: ☑️ agreed by dveeden.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 7, 2024

@dveeden To optimize the storage and costs for our CDN while reusing images across multiple versions, we currently "merge" all images under media/ across all branches and upload them to https://download.pingcap.com/images/docs/. This means we keep only one copy each image instead of one per branch. With 25 versions of TiDB docs in total, this approach saves significant storage space and costs. In most cases, we want to reuse images across versions to ensure consistency. Therefore, we cannot delete any images unless they are unused across all branches.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 7, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 82bc61a into pingcap:master Apr 7, 2024
7 of 9 checks passed
@Oreoxmt Oreoxmt deleted the revert-media-sqlgram branch December 31, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants