Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contribution guide: add EBNF preview and CustomContent instructions #16610

Merged
merged 10 commits into from
Mar 1, 2024
Merged

contribution guide: add EBNF preview and CustomContent instructions #16610

merged 10 commits into from
Mar 1, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Feb 27, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

  • Removed the Docs Dash information
  • Added the guideline for contributing to TiDB Cloud documentation
  • Added the guideline for previewing EBNF diagrams

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
qiancai
qiancai commented Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Feb 28, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@qiancai qiancai requested a review from lilin90 February 28, 2024 07:07
lilin90
lilin90 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 10:01:22.184766165 +0000 UTC m=+956170.932389274: ☑️ agreed by dveeden.
  • 2024-02-28 08:00:40.600479013 +0000 UTC m=+1035329.348102124: ☑️ agreed by lilin90.

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 1, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Mar 1, 2024
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
qiancai
qiancai commented Mar 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 1, 2024

/approve

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Mar 1, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 6902ccc into pingcap:master Mar 1, 2024
8 of 9 checks passed
@lilin90 lilin90 self-assigned this Apr 15, 2024
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 15, 2024
@lilin90 lilin90 mentioned this pull request Apr 15, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@dveeden dveeden dveeden approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @dveeden @lilin90