Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev-guide-wordpress.md #16094

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Update dev-guide-wordpress.md #16094

merged 2 commits into from
Jan 19, 2024

Conversation

minaelee
Copy link

What is changed, added or deleted? (Required)

  • add selecting a database to Part 3
  • add Part 5 for confirming connectivity
  • clarify sentence with ambiguous pronoun antecedent

Which TiDB version(s) do your changes apply to? (Required)

  • v7.5 (TiDB 7.5 versions)

What is the related PR or file link(s)?

Issue #16036

@minaelee
Update dev-guide-wordpress.md
d286b71 
- add selecting a database to Part 3
- add Part 5 for confirming connectivity
- clarify sentence with ambiguous pronoun antecedent
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@rpaik rpaik added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 11, 2024
@rpaik rpaik requested a review from qiancai January 11, 2024 00:16
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
@qiancai qiancai linked an issue Jan 11, 2024 that may be closed by this pull request
Debug TiDB Cloud Documentation: Connect to TiDB Serverless with WordPress #16036
Closed
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. and removed missing-translation-status This PR does not have translation status info. labels Jan 11, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 11, 2024

/cc @shizn

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 11, 2024

@qiancai: GitHub didn't allow me to request PR reviews from the following users: shizn.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @shizn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

@shizn: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 self-assigned this Jan 17, 2024
lilin90
lilin90 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 07:30:28.49289247 +0000 UTC m=+514818.077146158: ☑️ agreed by dveeden.
  • 2024-01-19 10:05:28.488145439 +0000 UTC m=+523170.052443139: ☑️ agreed by lilin90.

@lilin90
Copy link
Member

lilin90 commented Jan 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit a6cb631 into pingcap:release-7.5 Jan 19, 2024
9 checks passed
@minaelee minaelee deleted the patch-3 branch January 23, 2024 06:07
@qiancai qiancai mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@shizn shizn shizn approved these changes

@dveeden dveeden dveeden approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees

@lilin90 lilin90

Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug TiDB Cloud Documentation: Connect to TiDB Serverless with WordPress
6 participants
@minaelee @qiancai @lilin90 @dveeden @shizn @rpaik