Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic-features.md: add the column for v7.6.0 #16041

Merged
merged 10 commits into from
Jan 25, 2024
Merged

basic-features.md: add the column for v7.6.0 #16041

merged 10 commits into from
Jan 25, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jan 9, 2024

What is changed, added or deleted? (Required)

Add the column for v7.6.0

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.6 This PR/issue applies to TiDB v7.6. labels Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2024
@qiancai qiancai self-assigned this Jan 9, 2024
Oreoxmt
Oreoxmt reviewed Jan 9, 2024
View reviewed changes
basic-features.md Outdated Show resolved Hide resolved
@dveeden
Copy link
Contributor

dveeden commented Jan 9, 2024

Looks like this is a bit problematic with PDF rendering:
#15982

Some possible solutions:

  1. Remove pre-5.0 versions
  2. Use multiple tables (e.g put 3.x,4.x,5.x in one table and 6.x and 7.x in another)
  3. Use a vertical layout
  4. Limit the text length in the columns
  5. Turn the table 90° in the PDF

This might need a mix of these possible solutions.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added needs-cherry-pick-release-7.6 and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 22, 2024
@hfxsd hfxsd self-requested a review January 23, 2024 00:45
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Jan 23, 2024
Preview PR pingcap/docs#16041 and this preview is triggered from commit
adad5ab 
pingcap/docs@a092ccf
qiancai
qiancai commented Jan 23, 2024
View reviewed changes
basic-features.md
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview: https://pingcap-docsite-preview-git-v760-release-notes-qiancai.vercel.app/tidb/dev/basic-features

@qiancai
Copy link
Collaborator Author

qiancai commented Jan 23, 2024

Looks like this is a bit problematic with PDF rendering: #15982

Some possible solutions:

  1. Remove pre-5.0 versions
  2. Use multiple tables (e.g put 3.x,4.x,5.x in one table and 6.x and 7.x in another)
  3. Use a vertical layout
  4. Limit the text length in the columns
  5. Turn the table 90° in the PDF

This might need a mix of these possible solutions.

Looks like this is a bit problematic with PDF rendering: #15982

Some possible solutions:

  1. Remove pre-5.0 versions
  2. Use multiple tables (e.g put 3.x,4.x,5.x in one table and 6.x and 7.x in another)
  3. Use a vertical layout
  4. Limit the text length in the columns
  5. Turn the table 90° in the PDF

This might need a mix of these possible solutions.

Hi @dveeden, many thanks for reporting this issue. As some customers are still using pre-5.0 versions and might need to upgrade to newer versions, if we divide the table into multiple tables, they might find it difficult to compare the feature changes. So limiting the text length or column length looks more friendly.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 24, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 02:21:36.81659214 +0000 UTC m=+927338.380889844: ☑️ agreed by hfxsd.
  • 2024-01-24 02:42:53.627423762 +0000 UTC m=+928615.191721467: ☑️ agreed by Oreoxmt.

github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Jan 24, 2024
Preview PR pingcap/docs#16041 and this preview is triggered from commit
450c0d0 
pingcap/docs@0dd8d46
@qiancai
Copy link
Collaborator Author

qiancai commented Jan 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 25, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Jan 25, 2024

/verify

@ti-chi-bot ti-chi-bot bot merged commit 725873d into pingcap:master Jan 25, 2024
9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 25, 2024
@qiancai @ti-chi-bot
basic-features.md: add the column for v7.6.0 (pingcap#16041)
3bfc1ac
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 25, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16313.

qiancai added a commit that referenced this pull request Jan 25, 2024
@ti-chi-bot @qiancai
basic-features.md: add the column for v7.6.0 (#16041) (#16313)
d4d49b8 
Co-authored-by: Grace Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiancai @dveeden @ti-chi-bot @hfxsd @Oreoxmt