Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: add explanation for csv delimiter config #15877

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Dec 26, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2023
@lidezhu lidezhu changed the title ticdc: add explanation for csv delimiter configadd explanation for config ticdc: add explanation for csv delimiter config Dec 26, 2023
@hfxsd hfxsd self-assigned this Dec 26, 2023
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.6 This PR/issue applies to TiDB v7.6. labels Dec 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 26, 2023
@lidezhu lidezhu requested review from flowbehappy and benmeadowcroft and removed request for benmeadowcroft December 26, 2023 06:38
ticdc/ticdc-csv.md Outdated Show resolved Hide resolved
Co-authored-by: xixirangrang <[email protected]>
ticdc/ticdc-csv.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from ran-huang December 26, 2023 07:08
ticdc/ticdc-csv.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 26, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2023
Copy link

ti-chi-bot bot commented Dec 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-26 07:25:02.703955363 +0000 UTC m=+1550593.741182276: ☑️ agreed by ran-huang.
  • 2023-12-26 07:48:54.164157659 +0000 UTC m=+1552025.201384586: ☑️ agreed by hfxsd.

Copy link

ti-chi-bot bot commented Dec 26, 2023

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ticdc/ticdc-csv.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Dec 28, 2023

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ticdc/ticdc-csv.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jan 8, 2024

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 19, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 95d314a into master Jan 19, 2024
10 checks passed
PitifulPete pushed a commit to PitifulPete/tidb-docs that referenced this pull request Jan 19, 2024
@Oreoxmt Oreoxmt deleted the change-cdc-delimiter-config branch May 28, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants