Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: Update cdc server config #15012

Merged
merged 6 commits into from
Oct 17, 2023
Merged

ticdc: Update cdc server config #15012

merged 6 commits into from
Oct 17, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Oct 11, 2023 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement. labels Oct 11, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@qiancai qiancai requested a review from sdojjy October 11, 2023 06:01
qiancai
qiancai commented Oct 11, 2023
View reviewed changes
ticdc/ticdc-server-config.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt self-requested a review October 11, 2023 06:12
qiancai
qiancai commented Oct 13, 2023
View reviewed changes
ticdc/ticdc-server-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-server-config.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator Author

qiancai commented Oct 13, 2023

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt October 13, 2023 03:01
Oreoxmt
Oreoxmt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/ticdc-server-config.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-13 05:16:27.76917613 +0000 UTC m=+1374985.356286275: ☑️ agreed by Oreoxmt.

@qiancai qiancai added the lgtm label Oct 17, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Oct 17, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5a3da9a into pingcap:master Oct 17, 2023
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15108.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 17, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@ti-chi-bot
ticdc: Update cdc server config (#15012) (#15108)
fc132fc
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Dec 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15575.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 1, 2023
@ti-chi-bot
ticdc: Update cdc server config (#15012) (#15575)
4c1a319
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15577.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 1, 2023
@ti-chi-bot
ticdc: Update cdc server config (#15012) (#15577)
f967643
@hfxsd hfxsd mentioned this pull request Dec 1, 2023
Closed
18 tasks
@hfxsd hfxsd added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15579.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 1, 2023
@ti-chi-bot
ticdc: Update cdc server config (#15012) (#15579)
b53dbfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiancai @ti-chi-bot @sdojjy @Oreoxmt @lilin90 @hfxsd