Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: add the Storage Sink feature to ticdc-overview.md #14958

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Oct 7, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Close #14957

TiCDC v6.5.0 supports replicating changed logs to Amazon S3, Azure Blob Storage, NFS, and other S3-compatible storage services.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. ONCALL Relates to documentation oncall. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Oct 7, 2023
@Oreoxmt Oreoxmt self-assigned this Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 7, 2023

@benmeadowcroft PTAL

@benmeadowcroft
Copy link
Collaborator

benmeadowcroft commented Oct 9, 2023

The change you made looks good, but I would also suggest also updating the image on that page as well to include Object storage as a target. Perhaps you could add the attached image to your PR (replacing the current content of the image file /media/ticdc/cdc-architecture.png)

@benmeadowcroft
Copy link
Collaborator

Looks like the image I attached got left off my prior comment somehow, trying again!
cdc-architecture

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 11, 2023

@benmeadowcroft I have updated the architecture and the description in TiDB Migration Tools Overview, could you please help review these changes (387df20)? Thanks!

@benmeadowcroft
Copy link
Collaborator

@Oreoxmt yes, this PR addresses the issues I raised in #14957
Thank you!

@hfxsd hfxsd self-requested a review October 13, 2023 01:35
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-13 01:50:23.14182332 +0000 UTC m=+1362620.728933461: ☑️ agreed by hfxsd.

ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Oct 13, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit b17f60c into pingcap:master Oct 13, 2023
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15040.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15041.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #15042.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 13, 2023
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 13, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15043.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15044.

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 13, 2023
@Oreoxmt Oreoxmt deleted the fix/issue-14957 branch October 13, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiCDC Overview does not provide details about the Storage Sink capabilities
4 participants